Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page titles/headers more homogeneous #385

Closed
tcompa opened this issue Dec 21, 2023 · 6 comments · Fixed by #386
Closed

Make page titles/headers more homogeneous #385

tcompa opened this issue Dec 21, 2023 · 6 comments · Fixed by #386

Comments

@tcompa
Copy link
Collaborator

tcompa commented Dec 21, 2023

Current situation:

image
image
image
image
image

@zonia3000
Copy link
Collaborator

Technically h1 should be the preferred header to use for the main title of a page (also from accessibility perspective). However for me it looks a bit too heavy, so I combined it with Bootstrap fw-light to remove the bold. Let me know if you prefer something different.

I've also kept the breadcrumbs only on pages that have a parent page.

Ref f9f2199

image


image


image


image

@zonia3000 zonia3000 mentioned this issue Jan 9, 2024
1 task
@jluethi
Copy link
Collaborator

jluethi commented Jan 9, 2024

Great that this becomes more uniform. Here are some minor points:

  1. How does the Projects page (listing all the projects) look with this?
  2. Regarding bold vs. light: no strong opinion, I'm fine with this light one.
  3. Regarding breadcrumbs: The admin area doesn't necessarily need those, as admin area is a top-level link.
  4. Have these new headers been applied like this everywhere? e.g. dataset pages? I actually think we could drop the title in the dataset page (similar to the workflow page), because the info is in the breadcrumbs. Same for the workflow job page

Regarding breadcrumbs vs. titles: It looks to me like we could go either/or instead of having both on some pages => top-level pages have a title, but no breadcrumbs (because those links are in the header). Pages further down the hierarchy have breadcrumbs, but no title (like workflows atm). Would that make sense?

@zonia3000
Copy link
Collaborator

  1. How does the Projects page (listing all the projects) look with this?

With that commit projects page looks like this:

image

We can remove all the titles of the pages that are directly accessible from the main menu. In that case we could also highlight the currently active section (I think we already discussed about this), to make it clearer where we are:

image

  1. Have these new headers been applied like this everywhere? e.g. dataset pages? I actually think we could drop the title in the dataset page (similar to the workflow page), because the info is in the breadcrumbs. Same for the workflow job page

I applied them everywhere. Dataset page looks in this way:

image

I can remove the title and keep only the breadcrumbs.

Regarding breadcrumbs vs. titles: It looks to me like we could go either/or instead of having both on some pages => top-level pages have a title, but no breadcrumbs (because those links are in the header). Pages further down the hierarchy have breadcrumbs, but no title (like workflows atm). Would that make sense?

I think we could do the following:

  1. Pages directly accessible from the menu have no title, except when the title provides additional information (e.g. "Welcome to Fractal web client" in home);
  2. Pages that are a direct child of one of the main page have a title (e.g. "project X", "users list" under admin area);
  3. Keep the breadcrumbs and no title where there are more than 3 levels;
  4. Keep highlighted the current section in the main menu.

Regarding the first point, what about jobs page title? It says "Jobs of user X". Is this info useful to not confuse it with the admin jobs page? Could we rename the menu link to "My Jobs" and remove the title?

@jluethi
Copy link
Collaborator

jluethi commented Jan 9, 2024

We can remove all the titles of the pages that are directly accessible from the main menu. In that case we could also highlight the currently active section (I think we already discussed about this), to make it clearer where we are:

Oh, that's a great idea! Love it!

1-4 => perfect, let's go with that!

Regarding the first point, what about jobs page title? It says "Jobs of user X". Is this info useful to not confuse it with the admin jobs page? Could we rename the menu link to "My Jobs" and remove the title?

I don't think that's necessary for the job page. All our users don't have access to the Admin area. Plus, the admin area is marked with the nice red bar on top, so won't be confused :)
=> Let's also drop the title on the Jobs page

@zonia3000
Copy link
Collaborator

zonia3000 commented Jan 10, 2024

Some more screenshots:

image

image

image

image

image

image

image

image

image

image

image

@jluethi
Copy link
Collaborator

jluethi commented Jan 10, 2024

Looks great, thanks for the screenshots!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants