Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe give feedback when args "save" goes through #207

Closed
tcompa opened this issue Jun 22, 2023 · 3 comments
Closed

Maybe give feedback when args "save" goes through #207

tcompa opened this issue Jun 22, 2023 · 3 comments
Labels
JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas user interface

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jun 22, 2023

Especially when one tries the new args-schema component for the first time, a user will for sure fail to save for several possible reasons. After each attempt, one goes back to modify the values. At some point, after N failed attempts, one goes through. I think it'd be useful to display something like a "Arguments updated correctly" green message on top of the component, at least for a small time interval.

Low priority, and open to different suggestions.

@jluethi
Copy link
Collaborator

jluethi commented Jun 23, 2023

I'll have to play with the interface myself to get a feeling for this. One feedback that should already be there is that the save button becomes unclickable after successful save. Maybe that's enough?

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 23, 2023

One feedback that should already be there

It is already there, indeed.

In the current style the save-button style change is not very visible, hence this issue. But I agree: a clear style change for the "save" button will be enough.

@tcompa tcompa added fractal-server-1.3 user interface JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas and removed fractal-server-1.3 labels Jun 27, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Oct 17, 2023

Re-visiting this issue now, and I don't think it's worth implementing any additional feedback.

When there are possible changes to save, the button is dark and clickable:
image

When there are no changes, the button is shaded and non-clickable:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas user interface
Projects
None yet
Development

No branches or pull requests

2 participants