Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting a UserGroup (except for the default one) #1885

Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Oct 10, 2024

closes #1845
closes #1871

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Base automatically changed from new-task-collection to main October 10, 2024 12:57
@ychiucco ychiucco linked an issue Oct 10, 2024 that may be closed by this pull request
@tcompa tcompa self-requested a review October 10, 2024 13:12
Copy link

github-actions bot commented Oct 10, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.6 10.4 1.12 0.6 0.6
power 421.9 394.0 1.07 381.8 381.8
dataset 160.2 149.4 1.07 142.0 142.0
project 51.3 46.8 1.10 49.7 49.7
job 30.8 27.5 1.12 34.4 34.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 6.6 1.23 2.2 2.2
power 147.3 138.3 1.07 652.4 652.4
dataset 145.6 137.4 1.06 905.6 905.6
project 50.8 47.3 1.07 283.9 283.9
job 40.9 37.6 1.09 225.0 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.8 8.5 1.04 0.1 0.1
power 8.8 7.9 1.11 0.1 0.1
dataset 8.4 7.6 1.11 0.1 0.1
project 10.4 9.7 1.07 2.3 2.3
job 8.7 7.8 1.12 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.2 6.4 1.12 0.8 0.8
power 6.8 6.4 1.06 0.8 0.8
dataset 7.3 6.7 1.09 0.8 0.8
project 6.9 6.4 1.08 0.8 0.8
job 6.9 6.3 1.10 0.8 0.8

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.9 11.7 1.10 0.8 0.8
power 27.7 25.3 1.09 29.4 29.4
dataset 22.0 19.4 1.13 16.9 16.9
project 28.5 25.5 1.12 21.2 21.2
job 13.1 11.5 1.14 0.8 0.8

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 157.8 150.1 1.05 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 5.3 1.09 0.2 0.2
power 6.0 5.1 1.18 0.2 0.2
dataset 6.2 5.1 1.22 0.2 0.2
project 5.2 5.4 0.96 0.2 0.2
job 5.8 5.1 1.14 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 264.3 262.9 1.01 0.2 0.2

Copy link

github-actions bot commented Oct 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/auth
  _aux_auth.py
  group.py
  fractal_server/app/schemas/v2
  task_collection.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit f6fe40c into main Oct 10, 2024
18 checks passed
@tcompa tcompa deleted the 1845-allow-deleting-a-usergroup-apart-from-the-default-all-one branch October 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants