Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make convert_2D_segmentation_to_3D copy feature tables #9

Open
jluethi opened this issue Apr 30, 2024 · 2 comments
Open

Make convert_2D_segmentation_to_3D copy feature tables #9

jluethi opened this issue Apr 30, 2024 · 2 comments

Comments

@jluethi
Copy link
Collaborator

jluethi commented Apr 30, 2024

TBD details
@silvbarb Want to elaborate a bit?

@silvbarb
Copy link

Yes!

If the original data lives in (z,y,x) dimensions, and a z-projection is used for object measurements (example: 2D segmentation of organoids + basic 2D feature extraction), it would be nice to have such measurements copied to the 3D OME-Zarr as well, and not only to have them in the _mip.zarr

This would require the option to copy over from 2D to 3D specific ROI_table(s), which maybe could be specified by the user? I doubt for instance that the FOV or well_ROI_table it's something the user would want to lift over, but maybe the label_ROI_table, as well as the measurements tables could be interesting to have.

@jluethi
Copy link
Collaborator Author

jluethi commented Apr 30, 2024

This would require the option to copy over from 2D to 3D specific ROI_table(s), which maybe could be specified by the user? I doubt for instance that the FOV or well_ROI_table it's something the user would want to lift over, but maybe the label_ROI_table, as well as the measurements tables could be interesting to have.

Fully agreed!
You can already copy over label_ROI_table, as those are important to e.g. make 3D measurement per object from 2D. You can specify which ROI tables you want to copy over by using the ROI_tables_to_copy parameter of the task.

I see 2 ways to proceed:

  1. We add a second parameter: Other tables to copy
  2. We make the copying of tables smarter, now that our tables are typed. If it's a ROI table, we modify the Z dimension of the ROI as we currently do. If it's any other kind of table, we just copy over the table. The parameter could then be named just tables_to_copy.

I'd default to option 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants