Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Accept TaskUpdate.version=None #92

Closed
tcompa opened this issue Aug 24, 2023 · 0 comments · Fixed by #93
Closed

Accept TaskUpdate.version=None #92

tcompa opened this issue Aug 24, 2023 · 0 comments · Fixed by #93

Comments

@tcompa
Copy link
Collaborator

tcompa commented Aug 24, 2023

This came up during fractal-analytics-platform/fractal-web#173.

The use case is for when a user sets task.version="asdasd" by mistake for a task that is not meant to have a version, and then they want to reset it to None. Note that we should still reject version="".

Higher level: in principle this should be the behavior for all attributes of Update models that correspond to a nullable DB column. Let's postpone a more systematic refactoring, by now, and only implement it for TaskUpdate.

@ychiucco @zonia3000

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant