bug: anvil_dumpState full block load doesn't work

[samlaf]

Component

Anvil

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (3abac32 2024-06-20T00:22:07.769597000Z)

What command(s) is the bug in?

anvil --dump/load-state & cast block n --full

Operating System

macOS (Apple Silicon)

Describe the bug

This is a followup to #8160. There was a bug left in that PR, which is now affecting me. It seems like full block are not dumped properly:

$ cast block 1 --full
Error:
block Number(Number(1)) not found

Does anyone know what the difference between cast block n and cast block n --full, and any intuition as to why blocks can be found, but not full blocks?

When querying via geth's BlockByNumber (which queries https://www.quicknode.com/docs/ethereum/eth_getBlockByNumber), I get panics, which seems to indicate that geth sets the transaction_detail_flag to true (equivalent to -full flag in cast?)

[mattsse]

this looks more like an issue with how the state is reinserted

[samlaf]

Another weirdness we just noticed:

Start anvil chain with a loaded state (with block > 0). Then:

cast block-number // prints 200 (or whatever block the loaded state was dumped at)
cast block --rpc-url --field "number" // prints 0... ?!?!?!

and then if you cast rpc anvil_mine to advance the chain by 1 block. Now:

cast block-number // prints 201 (or whatever)
cast block --rpc-url --field "number" // prints 201 ?!?

[tuler]

This is affecting me as well. Any insight about why this happens, and a potential fix?
The dumped json state seems correct, the transactions are there.

[tuler]

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Lines 337 to 346 in 72e44fb

	/// Deserialize and add all blocks data to the backend storage
	pub fn load_blocks(&mut self, serializable_blocks: Vec<SerializableBlock>) {
	for serializable_block in serializable_blocks.iter() {
	let block: Block = serializable_block.clone().into();
	let block_hash = block.header.hash_slow();
	let block_number = block.header.number;
	self.blocks.insert(block_hash, block);
	self.hashes.insert(U64::from(block_number), block_hash);
	}
	}

state loading above is not hydrating the transactions memory structure below, only the blocks and hashes.

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Lines 214 to 230 in 72e44fb

	pub struct BlockchainStorage {
	/// all stored blocks (block hash -> block)
	pub blocks: HashMap<B256, Block>,
	/// mapping from block number -> block hash
	pub hashes: HashMap<U64, B256>,
	/// The current best hash
	pub best_hash: B256,
	/// The current best block number
	pub best_number: U64,
	/// genesis hash of the chain
	pub genesis_hash: B256,
	/// Mapping from the transaction hash to a tuple containing the transaction as well as the
	/// transaction receipt
	pub transactions: HashMap<TxHash, MinedTransaction>,
	/// The total difficulty of the chain until this block
	pub total_difficulty: U256,
	}

This makes the get below to fail, because transaction is not there.

foundry/crates/anvil/src/eth/backend/mem/mod.rs

Line 1545 in 72e44fb

let info = storage.transactions.get(&hash)?.info.clone();

[KholdStare]

Could this issue be related to #8179 ?