fix: dirty files detection #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #104. Right now we detect and remove dirty cache entries in
ArtifactsCacheInner::filterwhich is redundant as we can just do a single iteration over all cached files.Now file filtering is done in 2 steps:
ArtifactsCacheInner::find_and_remove_dirtydetects all dirty entries (even those that are not in scope of current compiler run) and removes them from cache.ArtifactsCacheInner::filterschedules for compilation all sources for which we are missing artifacts (either because of removed entry or because we never compiled given source with current version)