Skip to content

Commit 7665622

Browse files
committed
Merge branch 'develop' into feature/update-zurb-urls
# Conflicts: # docs/partials/footer.html # package.nuspec
2 parents 2aea14d + d1477a6 commit 7665622

20 files changed

+40
-39
lines changed

.commitlintrc.yml

+3
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
extends:
22
- '@commitlint/config-conventional'
3+
rules:
4+
subject-case: [0, always]
5+
subject-full-stop: [0, always]

.huskyrc.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
hooks:
22
commit-msg: >
3-
node ./script/husky-commit-lint.js --color -e $GIT_PARAMS &&
4-
node ./script/husky-commit-test.js --color
3+
node ./script/husky-commit-lint.js --color -e $GIT_PARAMS
54
pre-push:
65
node ./script/husky-push-test.js --color

LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright © 2011-2019 ZURB, Inc.
1+
Copyright © 2011-2020 ZURB, Inc.
22

33
MIT License
44

bower.json

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"code-of-conduct.md",
5151
"composer.json",
5252
"CONTRIBUTING.md",
53-
"docslink.sh",
5453
"gulpfile.js",
5554
"meteor-README.md",
5655
"package.js",

browserstack.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"username": "joeworkman",
3+
"key": "vutaD3ypYamTHAHQxP5Z",
24
"test_path": "test/javascript/index.html",
35
"test_framework": "mocha",
46
"exit_with_fail": true,
@@ -40,4 +42,4 @@
4042
"real_mobile": "true"
4143
}
4244
]
43-
}
45+
}

docs/layout/default.html

-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ <h5 class=""><strong>To master everything new in 6.4, along with the rest of Fou
4444
</div>
4545
</div>
4646

47-
{{> footer-contact}}
4847
{{> footer}}
4948
</div>
5049
</div>

docs/pages/flexbox-mode.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Flexbox mode is only supported in these browsers:
2525

2626
## Enabling Flexbox Mode
2727

28-
If you're using the CSS version of Foundation, you can generate a <a href="https://get.foundation/sites/download">custom download of Foundation</a> with flexbox mode enabled. If you're using the Sass version of Foundation, you can enable flexbox mode two ways:
28+
You can enable flexbox mode two ways:
2929

3030
If you use the `foundation-everything()` mixin in your main Sass file, pass in the parameter `true` to enable flexbox mode.
3131

docs/pages/installation.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ After you selected "Foundation for Sites", Foundation CLI will ask you which tem
205205
<li>Install the <a href="https://github.com/felixrieseberg/windows-build-tools">windows-build-tools</a> (recommended) and make python afterwards accessible via <code>npm config set python "%USERPROFILE%\.windows-build-tools\python27\python.exe"</code></li>
206206
<li>Install <a href="https://www.python.org/downloads/">python</a> (not recommended) and add it to your system environment variables</li>
207207
</ol>
208-
208+
209209
<p>The first way is recommended if you've not installed python v2.7 yet as it doesn't affect your machine outside the node environment. In case you've already installed python v2.7 you may of course skip both ways and start using foundationc-cli immediately.</p>
210210
</div>
211211

@@ -226,7 +226,7 @@ After you selected "Foundation for Sites", Foundation CLI will ask you which tem
226226
If you aren't into Sass, we have a starter template with compiled CSS and JavaScript, as well as a starting `index.html` file for you to hack on. Just unzip and get coding!
227227
</p>
228228
<p class="text-center">
229-
<a href="https://get.foundation/sites/download" class="button">Download Foundation</a>
229+
<a href="https://dhbhdrzi4tiry.cloudfront.net/downloads/releases/Foundation-6.6.1-CSS-project.zip" class="button">Download Foundation</a>
230230
</p>
231231
</div>
232232
</div>
@@ -239,23 +239,23 @@ The folks at [jsDelivr](https://www.jsdelivr.com) host the compressed Foundation
239239

240240
```html
241241
<!-- Compressed CSS -->
242-
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.4.3/dist/css/foundation.min.css" integrity="sha256-GSio8qamaXapM8Fq9JYdGNTvk/dgs+cMLgPeevOYEx0= sha384-wAweiGTn38CY2DSwAaEffed6iMeflc0FMiuptanbN4J+ib+342gKGpvYRWubPd/+ sha512-QHEb6jOC8SaGTmYmGU19u2FhIfeG+t/hSacIWPpDzOp5yygnthL3JwnilM7LM1dOAbJv62R+/FICfsrKUqv4Gg==" crossorigin="anonymous">
242+
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.6.1/dist/css/foundation.min.css" integrity="sha256-Q2fXBbKhtsyhYrSLa7hXCNV+FdhbQhyrjks8Kic0u/U=" crossorigin="anonymous">
243243

244244
<!-- Compressed JavaScript -->
245-
<script src="https://cdn.jsdelivr.net/npm/foundation-sites@6.4.3/dist/js/foundation.min.js" integrity="sha256-mRYlCu5EG+ouD07WxLF8v4ZAZYCA6WrmdIXyn1Bv9Vk= sha384-KzKofw4qqetd3kvuQ5AdapWPqV1ZI+CnfyfEwZQgPk8poOLWaabfgJOfmW7uI+AV sha512-0gHfaMkY+Do568TgjJC2iMAV0dQlY4NqbeZ4pr9lVUTXQzKu8qceyd6wg/3Uql9qA2+3X5NHv3IMb05wb387rA==" crossorigin="anonymous"></script>
245+
<script src="https://cdn.jsdelivr.net/npm/foundation-sites@6.6.1/dist/js/foundation.min.js" integrity="sha256-tdB5sxJ03S1jbwztV7NCvgqvMlVEvtcoJlgf62X49iM=" crossorigin="anonymous"></script>
246246
```
247247

248248
From Foundation 6.4, flex is enabled by default and **only the new XY Grid is available**. However, others CSS versions are available for backward compatibility and the most common usage cases. For others uses and advanced customization, we recommand to build Foundation with custom settings (see others installation methods).
249249

250250
```html
251251
<!-- foundation-float.min.css: Compressed CSS with legacy Float Grid -->
252-
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.4.3/dist/css/foundation-float.min.css" integrity="sha256-TPcVVrzfTETpAWQ8HhBHIMT7+DbszMr5n3eFi+UwIl8= sha384-+aXh7XSzITwlvjelsNWuL1A9rT8pWGaiqMMeUjtKcsWIfzT1oV8Mp3oYxmjPK8Gv sha512-cArttU/Yh+PzfQ/dhCdfBiU9+su+fuCwFxLrlLbvuJE/ynUbstaKweVPs7Hdbok9jlv9cwt+xdk20wRz7oYErQ==" crossorigin="anonymous">
252+
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.6.1/dist/css/foundation-float.min.css" integrity="sha256-4ldVyEvC86/kae2IBWw+eJrTiwNEbUUTmN0zkP4luL4=" crossorigin="anonymous">
253253

254254
<!-- foundation-prototype.min.css: Compressed CSS with prototyping classes -->
255-
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.4.3/dist/css/foundation-prototype.min.css" integrity="sha256-JyhZsgvsqjrdl9GPOILi/zyc+z4dcwXiyP1Q7cwWlM0= sha384-GtUT6gOaCY/S1ggTUOnqe5CQAEAZ6oVTmMq3X4vfZrvp+tLgjBEmwVxJnukor+o0 sha512-x3+KBxBjFh8PGncrfDOsJhntYDBFdJxmpb211THYkQOaGWvk7ckZG6prGUpZqz85AXgiispjow06+bDnIxnWDQ==" crossorigin="anonymous">
255+
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.6.1/dist/css/foundation-prototype.min.css" integrity="sha256-WkUTcNCS9N9OXBuGE0w6uYBiFviiIsM5JJK6JCol8jQ=" crossorigin="anonymous">
256256

257257
<!-- foundation-rtl.min.css: Compressed CSS with right-to-left reading direction -->
258-
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.4.3/dist/css/foundation-rtl.min.css" integrity="sha256-Az+E7JXW71Srarkum5QPTdnobddg2GqI1i8+nMusgLk= sha384-eBKuNtkGVmsJD0uNnWoKYYVnzDT0PXV+XNyAgmmZwYVn7MSNcaR4i5HjOpSRd0o6 sha512-d0RjiDZM/0NlD+7Y2DhUGuAUdwDIL5lS3GPAD0HEayEcrhuLuRiPYOgFWZik+gsFzsykxSn0KO6jim7ev8kIig==" crossorigin="anonymous">
258+
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/foundation-sites@6.6.1/dist/css/foundation-rtl.min.css" integrity="sha256-wgkuX4RG+TO0/QoU8TisMBs4hRb6OnWZeIk30YpfWHE=" crossorigin="anonymous">
259259
```
260260

261261
<div class="text-center">

docs/pages/prototyping-utilities.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Not all projects require Prototyping Utilities and adding utility classes like t
3434
</p>
3535
</div>
3636

37-
If you're using the CSS version of Foundation, you can generate a <a href="https://get.foundation/sites/download">custom download of Foundation</a> with prototype mode enabled. If you're using the Sass version of Foundation, you can enable prototype mode in two ways:
37+
You can enable prototype mode in two ways:
3838

3939
If you use the `foundation-everything()` mixin in your main Sass file, just pass in `$prototype: true` to enable the prototype mode.
4040

docs/pages/rtl.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ View of a [full list of language codes](https://www.loc.gov/standards/iso639-2/p
3131

3232
## CSS Download
3333

34-
If you use a CSS version of Foundation (the ones you can find on the [download page](https://get.foundation/sites/download)), you'll need to create a custom download that includes RTL CSS instead of LTR. Just select "Right-to-left" under the Text Direction section of the customizer.
34+
If you use a CSS version of Foundation (the ones you can find on the [download page](http://localhost:3000/installation.html#download)), you'll need to create a custom download that includes RTL CSS instead of LTR. Just select "Right-to-left" under the Text Direction section of the customizer.
3535

3636
---
3737

docs/pages/tabs.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ Put it all together, and we get this:
8282

8383
## Vertical Tabs
8484

85-
Add the `.vertical` class to a tabstrip to stack tabs vertically. You can also place the tabstrip and the tab contents in a grid to make them sit side-by-side.
85+
Add the `.vertical` class to a tabstrip and tab contents to stack tabs vertically. You can also remove the `.grid-margin-x` class from the wrapping div to make them sit side-by-side.
8686

8787
<p>
8888
<a class="" data-open-video="3:46"><img src="{{root}}assets/img/icons/watch-video-icon.svg" class="video-icon" height="30" width="30" alt=""> Watch this part in video</a>
@@ -94,7 +94,7 @@ Add the `.vertical` class to a tabstrip to stack tabs vertically. You can also p
9494

9595
```html_example
9696
<div class="grid-container">
97-
<div class="grid-x grid-margin-x">
97+
<div class="grid-x">
9898
<div class="cell medium-3">
9999
<ul class="vertical tabs" data-tabs id="example-tabs">
100100
<li class="tabs-title is-active"><a href="#panel1v" aria-selected="true">Tab 1</a></li>
@@ -106,7 +106,7 @@ Add the `.vertical` class to a tabstrip to stack tabs vertically. You can also p
106106
</ul>
107107
</div>
108108
<div class="cell medium-9">
109-
<div class="tabs-content" data-tabs-content="example-tabs">
109+
<div class="tabs-content vertical" data-tabs-content="example-tabs">
110110
<div class="tabs-panel is-active" id="panel1v">
111111
<p>One</p>
112112
<p>Check me out! I'm a super cool Tab panel with text content!</p>

docs/partials/navigation.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@
4040
<li><a href="https://zurb.com/university/courses">Courses</a></li>
4141
<li><a href="https://zurb.com/university/training">Custom Training</a></li>
4242
<li><a href="https://get.foundation/learn/certification.html">Certification</a></li>
43-
<li><a href="https://get.foundation/learn/responsive-reading.html">Responsive Reading</a></li>
43+
4444
</ul>
4545
</li>
4646

4747
<li class="menu-item">
4848
<a href="https://get.foundation/get-involved/support.html">Get Involved</a>
4949
<ul class="menu vertical">
5050
<li><a href="https://get.foundation/get-involved/support.html">Connect</a></li>
51-
<li><a href="https://get.foundation/get-involved/premium-support.html">PLZ Halp</a></li>
51+
5252
<li><a href="https://foundation.discourse.group">Foundation Forum</a></li>
5353
<li><a href="https://get.foundation/learn/events.html">Events</a></li>
5454
<li><a href="https://get.foundation/get-involved/faq.html">FAQs</a></li>
@@ -63,7 +63,7 @@
6363
<a href="https://get.foundation/frameworks-docs.html">Docs</a>
6464
<ul class="menu vertical">
6565
<li><a target="_blank" href="https://get.foundation/sites/docs/">Sites Docs</a></li>
66-
<li><a target="_blank" href="https://get.foundation/emails/docs">Emails Docs</a></li>
66+
<li><a target="_blank" href="https://get.foundation/emails/docs/">Emails Docs</a></li>
6767
</ul>
6868
</li>
6969

docs/partials/off-canvi.html

+2-4
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,13 @@
3838
<li><a href="https://get.foundation/learn/classes.html">Classes</a></li>
3939
<li><a href="https://get.foundation/learn/custom-training.html">Custom Training</a></li>
4040
<li><a href="https://get.foundation/learn/certification.html">Certification</a></li>
41-
<li><a href="https://get.foundation/learn/responsive-reading.html">Responsive Reading</a></li>
4241
</ul>
4342
</li>
4443

4544
<li>
4645
<a href="https://get.foundation/get-involved/support.html">Get Involved</a>
4746
<ul class="submenu menu vertical" data-submenu>
4847
<li><a href="https://get.foundation/get-involved/support.html">Connect</a></li>
49-
<li><a href="https://get.foundation/get-involved/premium-support.html">PLZ Halp</a></li>
5048
<li><a href="https://foundation.discourse.group">Foundation Forum</a></li>
5149
<li><a href="https://get.foundation/learn/events.html">Events</a></li>
5250
<li><a href="https://get.foundation/get-involved/faq.html">FAQs</a></li>
@@ -58,8 +56,8 @@
5856
<li>
5957
<a href="https://get.foundation/frameworks-docs.html">Docs</a>
6058
<ul class="submenu menu vertical" data-submenu>
61-
<li><a href="https://get.foundation/docs/" target="_blank">Sites Docs</a></li>
62-
<li><a href="https://zurb.com/ink/docs.php" target="_blank">Email Docs</a></li>
59+
<li><a target="_blank" href="https://get.foundation/sites/docs/">Sites Docs</a></li>
60+
<li><a target="_blank" href="https://get.foundation/emails/docs/">Emails Docs</a></li>
6361
</ul>
6462
</li>
6563

docslink.sh

-3
This file was deleted.

gulp/tasks/customizer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ gulp.task('customizer:zip', function (done) {
134134
var outputFolder = path.dirname(OUTPUT_DIR);
135135
var outputFileName = path.basename(OUTPUT_DIR);
136136

137-
fs.closeSync(fs.openSync(path.join(OUTPUT_DIR, 'css/app.css', 'w')));
138-
fs.closeSync(fs.openSync(path.join(OUTPUT_DIR, 'js/app.js', 'w')));
137+
fs.closeSync(fs.openSync(path.join(OUTPUT_DIR, 'css/app.css'), 'w'));
138+
fs.closeSync(fs.openSync(path.join(OUTPUT_DIR, 'js/app.js'), 'w'));
139139
fs.writeFileSync(path.join(OUTPUT_DIR, 'js/app.js'), '$(document).foundation()\n');
140140

141141
return gulp.src(path.join(OUTPUT_DIR, '/**/*'))

js/foundation.drilldown.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class Drilldown extends Plugin {
9090
var $link = $(this);
9191
var $sub = $link.parent();
9292
if(_this.options.parentLink){
93-
$link.clone().prependTo($sub.children('[data-submenu]')).wrap('<li data-is-parent-link class="is-submenu-parent-item is-submenu-item is-drilldown-submenu-item" role="menuitem"></li>');
93+
$link.clone().prependTo($sub.children('[data-submenu]')).wrap('<li data-is-parent-link class="is-submenu-parent-item is-submenu-item is-drilldown-submenu-item" role="none"></li>');
9494
}
9595
$link.data('savedHref', $link.attr('href')).removeAttr('href').attr('tabindex', 0);
9696
$link.children('[data-submenu]')

js/foundation.dropdownMenu.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ class DropdownMenu extends Plugin {
5858
var subs = this.$element.find('li.is-dropdown-submenu-parent');
5959
this.$element.children('.is-dropdown-submenu-parent').children('.is-dropdown-submenu').addClass('first-sub');
6060

61-
this.$menuItems = this.$element.find('[role="menuitem"]');
62-
this.$tabs = this.$element.children('[role="menuitem"]');
61+
this.$menuItems = this.$element.find('li[role="none"]');
62+
this.$tabs = this.$element.children('li[role="none"]');
6363
this.$tabs.find('ul.is-dropdown-submenu').addClass(this.options.verticalClass);
6464

6565
if (this.options.alignment === 'auto') {
@@ -113,10 +113,12 @@ class DropdownMenu extends Plugin {
113113
|| (_this.options.forceFollow && hasTouch)) {
114114
return;
115115
}
116+
e.stopImmediatePropagation();
116117
e.preventDefault();
117118
_this._hide($elem);
118119
}
119120
else {
121+
e.stopImmediatePropagation();
120122
e.preventDefault();
121123
_this._show($sub);
122124
$elem.add($elem.parentsUntil(_this.$element, `.${parClass}`)).attr('data-is-click', true);
@@ -150,7 +152,7 @@ class DropdownMenu extends Plugin {
150152
_this._show($elem.children('.is-dropdown-submenu'));
151153
}, _this.options.hoverDelay));
152154
}
153-
}).on('mouseleave.zf.dropdownmenu', ignoreMousedisappear(function (e) {
155+
}).on('mouseleave.zf.dropdownMenu', ignoreMousedisappear(function (e) {
154156
var $elem = $(this),
155157
hasSub = $elem.hasClass(parClass);
156158
if (hasSub && _this.options.autoclose) {
@@ -164,7 +166,7 @@ class DropdownMenu extends Plugin {
164166
}));
165167
}
166168
this.$menuItems.on('keydown.zf.dropdownMenu', function(e) {
167-
var $element = $(e.target).parentsUntil('ul', '[role="menuitem"]'),
169+
var $element = $(e.target).parentsUntil('ul', '[role="none"]'),
168170
isTab = _this.$tabs.index($element) > -1,
169171
$elements = isTab ? _this.$tabs : $element.siblings('li').add($element),
170172
$prevElement,

js/foundation.util.nest.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ import $ from 'jquery';
55
const Nest = {
66
Feather(menu, type = 'zf') {
77
menu.attr('role', 'menubar');
8+
menu.find('a').attr({'role': 'menuitem'});
89

9-
var items = menu.find('li').attr({'role': 'menuitem'}),
10+
var items = menu.find('li').attr({'role': 'none'}),
1011
subMenuClass = `is-${type}-submenu`,
1112
subItemClass = `${subMenuClass}-item`,
1213
hasSubClass = `is-${type}-submenu-parent`,

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"deploy": "gulp deploy --color",
2626
"deploy:prep": "gulp deploy:prep --color",
2727
"deploy:docs": "gulp deploy:docs --color",
28-
"deploy:beta": "gulp deploy:beta --color"
28+
"deploy:beta": "gulp deploy:beta --color",
29+
"docs:link": "git clone https://github.com/foundation/foundation-docs && npm link ./foundation-docs"
2930
},
3031
"peerDependencies": {
3132
"jquery": ">=2.2.0",

package.nuspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<projectUrl>https://get.foundation/sites</projectUrl>
1414
<iconUrl>https://get.foundation/assets/img/icons/foundation-favicon.ico</iconUrl>
15-
<releaseNotes>https://github.com/foundation/foundation-sites/releases/tag/v6.5.3</releaseNotes>
15+
<releaseNotes>https://github.com/foundation/foundation-sites/releases/tag/v6.6.1</releaseNotes>
1616
<licenseUrl>https://github.com/foundation/foundation-sites/blob/develop/LICENSE</licenseUrl>
1717
<copyright>Copyright 2017-2018</copyright>
1818
<repository type="git" url="https://github.com/foundation/foundation-sites"/>

0 commit comments

Comments
 (0)