Add mypy static checker tool #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeyma
requested review from
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
2 tasks
Added to tox as `mypy` target Signed-off-by: Martin Hickey <[email protected]>
chichun-charlie-liu
approved these changes
Jan 21, 2025
chichun-charlie-liu
merged commit 4335a9d
into
foundation-model-stack:main
11 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Python is a dynamic language and does not use static type checking. It instead prevents typing errors at runtime . It
mypy is a standard open source static typing tool for Python which is widely used. This PR adds
mypyas tox targetmypy.Note: The suggestions from
mypywill be applied to the files in a follow PR and static checking enabled in CI/CD by default.Related issue number
Partial #33
How to verify the PR
Running it:
tox -e mypyWas the PR tested