Missmatch in orbitnumber in netcdf filename and posttroll message tag 'orbit_number' VIIRS when using level 1c runner in pytroll pps runner

[TAlonglong]

Problem description

When sending in VIIRS data like this: (posttroll message)

{'orig_platform_name': 'npp', 'start_time': datetime.datetime(2021, 11, 25, 8, 53, 5), 'start_decimal': 4
, 'end_time': datetime.datetime(1900, 1, 1, 8, 54, 29), 'end_decimal': 6, 'orbit_number': 52224, 'proctime': '20211125090537000265', 'stream': 'eumetcast', 'variant
': 'EARS', 'format': 'PPS', 'type': 'HDF5', 'data_processing_level': '2', 'platform_name': 'Suomi-NPP', 'tle_platform_name': 'SUOMI NPP', 'antenna': 'ears', 'origin
': '157.249.16.188:9227', 'dataset': [{'uri': '/data/pytroll/eum-sdr/GDNBO_npp_d20211125_t0853054_e0854296_b52224_c20211125090735000933_eum_ops.h5', 'uid': 'GDNBO_n
pp_d20211125_t0853054_e0854296_b52224_c20211125090735000933_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVDNB_npp_d20211125_t0853054_e0854296_b52224_c2021112509073
9000552_eum_ops.h5', 'uid': 'SVDNB_npp_d20211125_t0853054_e0854296_b52224_c20211125090739000552_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/GMODO_npp_d20211125_t08
53054_e0854296_b52224_c20211125090800000785_eum_ops.h5', 'uid': 'GMODO_npp_d20211125_t0853054_e0854296_b52224_c20211125090800000785_eum_ops.h5'}, {'uri': '/data/pyt
roll/eum-sdr/SVM01_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000875_eum_ops.h5', 'uid': 'SVM01_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000
875_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM02_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000888_eum_ops.h5', 'uid': 'SVM02_npp_d20211125_t085305
4_e0854296_b52224_c20211125090802000888_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM03_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000902_eum_ops.h5',
 'uid': 'SVM03_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000902_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM04_npp_d20211125_t0853054_e0854296_b5222
4_c20211125090802000914_eum_ops.h5', 'uid': 'SVM04_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000914_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM05_n
pp_d20211125_t0853054_e0854296_b52224_c20211125090802000931_eum_ops.h5', 'uid': 'SVM05_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000931_eum_ops.h5'}, {'
uri': '/data/pytroll/eum-sdr/SVM06_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000943_eum_ops.h5', 'uid': 'SVM06_npp_d20211125_t0853054_e0854296_b52224_c2
0211125090802000943_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM07_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000953_eum_ops.h5', 'uid': 'SVM07_npp_d
20211125_t0853054_e0854296_b52224_c20211125090802000953_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM08_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000
961_eum_ops.h5', 'uid': 'SVM08_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000961_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM09_npp_d20211125_t085305
4_e0854296_b52224_c20211125090802000970_eum_ops.h5', 'uid': 'SVM09_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000970_eum_ops.h5'}, {'uri': '/data/pytroll
/eum-sdr/SVM10_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000979_eum_ops.h5', 'uid': 'SVM10_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000979_
eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM11_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000987_eum_ops.h5', 'uid': 'SVM11_npp_d20211125_t0853054_e0
854296_b52224_c20211125090802000987_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM12_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000994_eum_ops.h5', 'ui
d': 'SVM12_npp_d20211125_t0853054_e0854296_b52224_c20211125090802000994_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM13_npp_d20211125_t0853054_e0854296_b52224_c2
0211125090803000002_eum_ops.h5', 'uid': 'SVM13_npp_d20211125_t0853054_e0854296_b52224_c20211125090803000002_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM14_npp_d
20211125_t0853054_e0854296_b52224_c20211125090803000009_eum_ops.h5', 'uid': 'SVM14_npp_d20211125_t0853054_e0854296_b52224_c20211125090803000009_eum_ops.h5'}, {'uri'
: '/data/pytroll/eum-sdr/SVM15_npp_d20211125_t0853054_e0854296_b52224_c20211125090803000016_eum_ops.h5', 'uid': 'SVM15_npp_d20211125_t0853054_e0854296_b52224_c20211
125090803000016_eum_ops.h5'}, {'uri': '/data/pytroll/eum-sdr/SVM16_npp_d20211125_t0853054_e0854296_b52224_c20211125090803000023_eum_ops.h5', 'uid': 'SVM16_npp_d2021
1125_t0853054_e0854296_b52224_c20211125090803000023_eum_ops.h5'}], 'sensor': ['viirs']}

And the resulting posttroll message from level 1c runner:

{"orig_platform_name": "npp", "start_time": "2021-11-25T08:53:05", "start_decimal": 4, "end_time": "1900-01-01T08:54:29", "end_decimal": 6, "orbit_number": 99999, "proctime": "20211125090537000265", "stream": "eumetcast", "variant": "EARS", "format": "PPS-L1C", "type": "NETCDF", "data_processing_level": "1c", "platform_name": "Suomi-NPP", "tle_platform_name": "SUOMI NPP", "antenna": "ears", "origin": "157.249.16.188:9227", "sensor": ["viirs"], "orig_orbit_number": 52224, "uri": "ssh://pps-v2021-a/data/pytroll/nwcsaf/import/IMAGER_data/S_NWC_viirs_npp_00000_20211125T0853054Z_20211125T0854296Z.nc", "uid": "S_NWC_viirs_npp_00000_20211125T0853054Z_20211125T0854296Z.nc"}

What I see in the code is https://github.com/foua-pps/level1c4pps/blob/master/level1c4pps/__init__.py#L383 where orbit_number is hardcoded to 0. This is then used in the filename: https://github.com/foua-pps/level1c4pps/blob/master/level1c4pps/__init__.py#L528-L536

But the message orbit_number is not used. That is, it is not possible to pass this to this module https://github.com/foua-pps/level1c4pps/blob/master/level1c4pps/viirs2pps_lib.py#L127-L128

So my problem it is not possible to control the use of orbit_number in the netcdf filename when calling this from eg level1c runner in pytroll pps runner.

[ninahakansson]

@TAlonglong Do you have any comments on the solution in PR #67?