Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Template Updated #502

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pull Request Template Updated #502

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f891be
only images accepted
neeraj3029 Nov 22, 2018
2f255eb
Merge branch 'master' of https://github.com/fossasia/susi_chromebot
neeraj3029 Dec 6, 2018
46d5f41
Merge branch 'master' of https://github.com/fossasia/susi_chromebot
neeraj3029 Dec 10, 2018
ae7dea8
PR template updated
neeraj3029 Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<!-- Add the issue number that is fixed by this PR (In the form Fixes #123) -->

Fixes #
[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as already at line 4 description about it is given. You can edit that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both lines have different meanings, please see carefully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I am saying that please edit at line 4 to merge both information. As both are related to issue number.


#### Checklist

Expand All @@ -15,6 +16,9 @@ Fixes #
<!-- If an existing function does not have a docstring, please add one -->
- [ ] All the functions created/modified in this PR contain relevant docstrings.

#### Screenshots for the change:


#### Short description of what this resolves:


Expand Down