Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No email field checker inside signup.js #553

Open
1 of 3 tasks
harshit-soora opened this issue Dec 13, 2020 · 0 comments · May be fixed by #554
Open
1 of 3 tasks

No email field checker inside signup.js #553

harshit-soora opened this issue Dec 13, 2020 · 0 comments · May be fixed by #554

Comments

@harshit-soora
Copy link

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support requests here, instead ask your query in our Gitter channel

Current behavior:

The code does restrict the user if they enter any malicious script code inside the email field of signup.html page

Expected behavior:

The behavior remains same, but provide a stability that it checks the edit field inside the same script(signup.js) rather than going into another script file and checking whether the written email in input field of signup.html is in right regular-language structure of an email.

Steps to reproduce:

Say if we enter some email like soora<html>.com inside the email field of signup.html then the script signup.js doesn't check this explicit behavior rather checked in some other(future) script. This isn't the right behavior one should expect and should be resolved in the script file of the given page itself.

This is implemented inside the script file for login.html page but not for signup.html

Related code:

var email=document.getElementById("email").value;
if(!email){
	alert("Email field cannot be empty");
	return;
}

I am using Ubuntu 20.04

Would you like to work on the issue?

Yes, I will complete it myself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a field checker to discard malicious script code in email field
1 participant
@harshit-soora