Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run container using CLI arguments instead of environment variables #6598

Closed
iamareebjamal opened this issue Nov 15, 2019 · 1 comment · Fixed by #6690
Closed

Run container using CLI arguments instead of environment variables #6598

iamareebjamal opened this issue Nov 15, 2019 · 1 comment · Fixed by #6690
Labels

Comments

@iamareebjamal
Copy link
Member

Currently, the container is started using an environment variable to decide if server or celery instance will be run. It makes it difficult to modify the image for quick edits when running.

export DEPLOYMENT=${DEPLOYMENT:-api}
echo "[LOG] Deploying ${DEPLOYMENT}"
echo "[LOG] Using database: ${DATABASE_URL}"
echo "[LOG] Using redis: ${REDIS_URL}"
if [ "$DEPLOYMENT" == "api" ]
then

if [ "$DEPLOYMENT" == "celery" ]
then
echo "[LOG] Starting celery worker"

Instead it should be run via CLI arguments. Like

./container_start.sh run api or ./container_start.sh run celery

@codedsun
Copy link
Contributor

taking this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants