Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multiple_heads is not raising the expected error #5988

Closed
shreyanshdwivedi opened this issue Jun 3, 2019 · 11 comments · Fixed by #7579
Closed

test_multiple_heads is not raising the expected error #5988

shreyanshdwivedi opened this issue Jun 3, 2019 · 11 comments · Fixed by #7579

Comments

@shreyanshdwivedi
Copy link
Member

shreyanshdwivedi commented Jun 3, 2019

Describe the bug

On having multiple heads, the travis build fails with error -

error: Hooks handler process 'dredd-hooks-python ./tests/hook_main.py' exited with status: 1
warn: Hook handling timed out.
error: Hooks handler process 'dredd-hooks-python ./tests/hook_main.py' exited with status: 1
info: Backend server process exited
The command "dredd" failed and exited with 1 during .

It should raise error as expected in - https://github.com/fossasia/open-event-server/blob/development/scripts/test_multiple_heads.sh

Expected behavior

Expected error should be raised - Error: Multiple Migration Heads

Additional context

On it

@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Jun 18, 2019

@iamareebjamal I think this issue is non-existent now. I just got error for this travis failure - https://travis-ci.org/fossasia/open-event-server/builds/547072348?utm_source=github_status&utm_medium=notification

Error: Multiple heads are present; please specify a single target revision

@iamareebjamal
Copy link
Member

Sometimes it fails correctly, sometimes it doesn't

@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal what should be done then? I'm unable to reproduce it for now

@iamareebjamal
Copy link
Member

Increase the milestone

@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal I don't have access. 😅
Please do so

@shreyanshdwivedi
Copy link
Member Author

It is not reproducible till now. Encountered correct error message twice this week

@iamareebjamal iamareebjamal reopened this Jul 2, 2019
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal I saw correct error message in this travis failure -
info: Hooks handler stderr: ERROR [root] Error: Multiple heads are present; please specify a single target revision

@iamareebjamal
Copy link
Member

That's not the point of the script. That's flask failure, unrelated to script. The script is meant to stop the build ASAP as it encounters multiple heads and not continue dredd tests and others

@kushthedude
Copy link
Member

@iamareebjamal
Copy link
Member

Nope. That's failure during installing dredd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants