Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync creates unnecessary sub folders #19

Closed
fortysix2ahead opened this issue Nov 14, 2023 · 1 comment · Fixed by #26
Closed

Sync creates unnecessary sub folders #19

fortysix2ahead opened this issue Nov 14, 2023 · 1 comment · Fixed by #26
Assignees
@fortysix2ahead
Labels
bug Something isn't working

Comments

@fortysix2ahead
Copy link
Owner

Seems to happen with albums containing whitespaces.
@fortysix2ahead fortysix2ahead added the bug Something isn't working label Nov 14, 2023
@fortysix2ahead fortysix2ahead self-assigned this Nov 14, 2023
@fortysix2ahead
Copy link
Owner Author

It's not about whitespaces. Synology allows characters like '/' for album names, which are then translated to paths. Which allows path traversals ...
Maybe the folder structure should not be id - album/file, but something else.

@fortysix2ahead fortysix2ahead mentioned this issue Nov 16, 2023
Merged
@fortysix2ahead fortysix2ahead linked a pull request Nov 16, 2023 that will close this issue
Use folder id for path creation instead of album id/name #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fortysix2ahead fortysix2ahead

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use folder id for path creation instead of album id/name fortysix2ahead/synophotos
1 participant
@fortysix2ahead