Validate setFieldTouched with high priority.
#2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avocadowastaken
requested review from
jaredpalmer and
johnrom
as code owners
🦋 Changeset detectedLatest commit: b4ea037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@umidbekkarimov is attempting to deploy a commit to the Formium Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/formik/ba9vokmkd |
jaredpalmer
approved these changes
Nov 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another follow up fix for the #2841.
In 2.2.0
validateFormWithLowPrioritywas immideatly called byunstable_runWithPriorityhttps://github.com/formium/formik/blob/7279751518089fac6a446b8a3b9c46035b65ea23/packages/formik/src/Formik.tsx#L329-L332
But 2.2.1 it was delayed, so when we validate values only on blur, users could see the error for few milliseconds.
Here is the repro #2841 (comment)