Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New check: Give us advance warning of glyphs which would be inaccessible due to subsetting #4097

Closed
felipesanches opened this issue Mar 16, 2023 · 4 comments
Closed

New check: Give us advance warning of glyphs which would be inaccessible due to subsetting #4097

felipesanches opened this issue Mar 16, 2023 · 4 comments
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Mar 16, 2023 •
edited by simoncozens
Loading

@m4rc1e found out today that the glyph palette view on the Google Fonts website isn't displaying glyphs with double marks well for Roboto Serif.
unnamed

@simoncozens thought this was due to the Google Fonts subsetter because he had recently been dealing with googlefonts/nam-files#6. It probably isn't, but it would be useful to have a list (and probably a warning) for any encoded codepoints within the font which do not fall into any of the glyphsets for the subsets defined in the font's METADATA.pb, making them effectively unreachable.
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Mar 16, 2023
@simoncozens simoncozens changed the title New check: Give us advance warning of how badly the subsetter is going to break a font New check: Give us advance warning of glyphs which would be inaccessible due to subsetting Mar 17, 2023
@simoncozens simoncozens mentioned this issue Mar 17, 2023
Merged
3 tasks
@khaledhosny
Copy link
Contributor

Many fonts include more glyphs that the subsets defined by Google Fonts, so the check is going to be more ignored noise.

@khaledhosny
Copy link
Contributor

(for example, the arabic subest only covers a fraction of the Arabic Unicode blocks).

@simoncozens
Copy link
Collaborator

That is an indicator of a problem that we want to know about, so we can fix it.

@simoncozens
Copy link
Collaborator

I think I did this with com.google.fonts/check/metadata/unreachable_subsetting.

@kateliev kateliev mentioned this issue Aug 7, 2024
Closed
@vv-monsalve vv-monsalve mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khaledhosny @simoncozens @felipesanches