Skip to content

Commit 596edf5

Browse files
simoncozensfelipesanches
authored andcommitted
Don't check for dotted circles in Hangul fonts.
Hangul is not a syllabic script. Old Hangeul uses complex shaping and has diacritic marks that require dotted circles. Contemporary Hangeul does not. com.google.fonts/check/dotted_circle On the Shaping Profile (related to issue #3600)
1 parent 21bccc5 commit 596edf5

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Below are the most important changes from each release.
1+
Below are the noteworthy changes from each release.
22
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).
33

44
## Upcoming release: 0.10.10 (2024-Jan-??)
@@ -7,6 +7,9 @@ A more detailed list of changes is available in the corresponding milestones for
77
- Fix a crash when no matching checks are found during a multi-processing run. Also, do not freeze indefinitely. Instead, terminate the program emitting a process error code -1 and giving the user some guidance. (issue #4420)
88

99
### Changes to existing checks
10+
#### On the Shaping Profile
11+
- ""[com.google.fonts/check/dotted_circle]:** Don't check for dotted circles in Hangul fonts. Hangul is not a syllabic script. Old Hangeul uses complex shaping and has diacritic marks that require dotted circles. Contemporary Hangeul does not. (related to issue #3600)
12+
1013
#### On the Google Fonts Profile
1114
- **[com.google.fonts/check/varfont/duplexed_axis_reflow]:** yield FAILs per incorrect axis (message codes specifying axis); sort the list of bad glyphs (PR #4400)
1215
- **[com.google.fonts/check/legacy_accents]:** We changed our minds here, and removed the overide to FAIL on "legacy-accents-component", so it is back a mere WARN again, just like in the Universal Profile (issue #4425)

Lib/fontbakery/profiles/shaping.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ def is_complex_shaper_font(ttFont):
475475
script = ot_tag_to_script(rec.ScriptTag)
476476
if script in USE_SCRIPTS or script in INDIC_SCRIPTS:
477477
return True
478-
if script in ["Khmr", "Mymr", "Hang"]:
478+
if script in ["Khmr", "Mymr"]:
479479
return True
480480
return False
481481

0 commit comments

Comments
 (0)