Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHI Angular Highcharts: Heisann, kan det ha skjedd noe med kart i den nye releasen? (4.4.0) #685

Closed
proand opened this issue Sep 18, 2024 · 4 comments · Fixed by #688
Closed
Assignees
Labels
Bug Something isn't working Status: Confirmed Confirmed as valid by a maintainer

Comments

@proand
Copy link
Member

proand commented Sep 18, 2024

Description

image

What was the expected result?

Skulle helst ikke hatt noe kart-knapp i det hele tatt

What browsers are you seeing the problem on?

No response

What framework are you using?

No response

Steps to reproduce

Ikke legg til items.mapTypes

Relevant log output (e.g web browser console logs)

No response

Additional information

Legger en til:
image
...så forsvinner knappen, men i forrige release ble den vist dersom jeg ikke la til mapTypes i items

@proand proand added Bug Something isn't working Status: Unconfirmed Not yet confirmed as valid by a maintainer (added by default) Status: Confirmed Confirmed as valid by a maintainer and removed Status: Unconfirmed Not yet confirmed as valid by a maintainer (added by default) labels Sep 18, 2024
@proand proand self-assigned this Sep 18, 2024
@proand
Copy link
Member Author

proand commented Sep 18, 2024

FYI @stalehaugenes @bittakv

@proand
Copy link
Member Author

proand commented Sep 18, 2024

@bittakv @stalehaugenes

Bare sånn for å være på den sikre siden:

Dette gir en meny med alle diagramtyper som finnes tilgjenglig i komponenten pr. i dag

controls: {
  navigation: {
    show: true,
  },
},

Dette gir en meny med kun tabell (og er m.a.o. selve bugfix-en som gjøres på dette issuet)

controls: {
  navigation: {
    items: {},
    show: true,
  },
},

Dette gir en meny tabell, pluss det som er definert, i den rekkefølgend de ligger i array-ene

controls: {
  navigation: {
    items: {
      chartTypes: ['bar', 'column', 'line', 'pie'],
      mapTypes: ['mapFylker2023'],
    },
    show: true,
  },
},

...er det som forventet og OK?

@bittakv
Copy link
Contributor

bittakv commented Sep 18, 2024

LGTM :-)

@proand
Copy link
Member Author

proand commented Sep 18, 2024

@bittakv Det blir en liten oppdatering etter innspill fra @stalehaugenes : eks 1 vil oppføre seg på akkurat samme måte som eks 2. Jeg ble overbevist; er det som gir mest mening. MEN: det blir en breaking, så da venter jeg med denne fix-en til v5 (m.a.o. Angular 18).

PS. Det en nå mister er det å lett kunne vise alle diagramtyper som finnes, uten å måtte angi dem, men jeg har kommet til at i grunn er en ganske søkt use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Status: Confirmed Confirmed as valid by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants