Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FHI Angular Highcharts: document how units work #613

Closed
proand opened this issue Jun 17, 2024 · 0 comments · Fixed by #615
Closed

FHI Angular Highcharts: document how units work #613

proand opened this issue Jun 17, 2024 · 0 comments · Fixed by #615
Assignees
@proand
Labels
Documentation Improvements or additions to documentation

Comments

@proand
Copy link
Member

proand commented Jun 17, 2024 •
edited
Loading

Description

The logic concerning FhiDiagramOptions.units is a bit cryptic. Try to document it so that it's possible to understand for new users of the component.

Also add missing FhiDiagramSerie.unitId in the API-doc.

Acceptance Criteria

  1. Go to https://github.com/folkehelseinstituttet/Fhi.Frontend.Demo/blob/dev/projects/fhi-angular-highcharts/README.md#interface-fhidiagramserie
  2. Check that the documentation make sense
  3. Go to https://github.com/folkehelseinstituttet/Fhi.Frontend.Demo/blob/dev/projects/fhi-angular-highcharts/README.md#interface-fhidiagramunit
  4. Check that the documentation make sense
@proand proand added the Documentation Improvements or additions to documentation label Jun 17, 2024
@proand proand self-assigned this Jun 17, 2024
@proand proand mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proand proand

Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update API-doc for FHI Angular Highcharts folkehelseinstituttet/Fhi.Frontend.Demo
1 participant
@proand