Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: flash.treesitter preselects "a" label even if the user has defined custom labels #9

Closed
3 tasks done
IndianBoy42 opened this issue Jun 21, 2023 · 1 comment · Fixed by #3
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@IndianBoy42
Copy link
Contributor

Did you check docs and existing issues?

  • I have read all the flash.nvim docs
  • I have searched the existing issues of flash.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.0-dev-541+g96b94f8d7

Operating system/version

Pop!_OS 22.04 LTS

Describe the bug

This line basically assumes that a is the first label:

https://github.com/folke/flash.nvim/blob/455ba61cd0e48b9e3a28e9e1fa1a3364d57e7538/lua/flash/plugins/treesitter.lua#LL66C30-L66C31

Steps To Reproduce

  1. config.modes.treesitter.labels = "fdsajkl"
  2. vS and see the labels and selection

Expected Behavior

The inner most treesitter node should be preselected (now labelled by f). Instead the node labelled a is selected.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	{
		"folke/flash.nvim",
		opts = {
			modes = {
				treesitter = { labels = "zayx" },
			},
		},
		keys = {
			{
				"S",
				mode = { "o", "x" },
				function()
					require("flash").treesitter()
				end,
			},
		},
	},
	-- add any other plugins here
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@IndianBoy42 IndianBoy42 added the bug Something isn't working label Jun 21, 2023
@folke folke closed this as completed in 3fac625 Jun 21, 2023
@folke
Copy link
Owner

folke commented Jun 21, 2023

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants