GoogleJSON directories#get does not accept a prefix option

[tcdowney]

In the older GoogleXML implementation you could pass this call a prefix option that would only fetch objects in the bucket that began with that prefix.

For example, this would only return objects directly under the 06824f8f-d185-409f-be75-55dba0a9a904 directory:

prefix = ' buildpack_cache/06/82/06824f8f-d185-409f-be75-55dba0a9a904'
connection.directories.get(dir.key, prefix: prefix).files

The newer API implementation no longer accepts prefix.

fog-google/lib/fog/storage/google_json/models/directories.rb

Line 12 in 2d8da68

def get(bucket_name,

Is there a way that support for the prefix option could be maintained?

Thanks!
Tim Downey && @maryamklabib

[icco]

I think the fact that worked before is a bug in the xml code. I would expect the call to be

connection.directories.get(dir.key).files(prefix: prefix)

For example the list call for files supports prefix in both APIs: https://cloud.google.com/storage/docs/json_api/v1/objects/list and https://cloud.google.com/storage/docs/xml-api/get-bucket-list

[tcdowney]

Hmm that's interesting. We'll test out calling it that way with fog-aws as well. Thanks!

[icco]

👍

[tcdowney]

@icco

It actually looks like we can't pass any arguments to directory#files. When we do we're getting an ArgumentError wrong number of arguments (given 1, expected 0) here:

/stuff/fog-google-8beb64921385/lib/fog/storage/google_json/model
s/directory.rb:40:in `files'

fog-google/lib/fog/storage/google_json/models/directory.rb

Lines 40 to 47 in 4647ce1

	def files
	@files ||= begin
	Fog::Storage::GoogleJSON::Files.new(
	:directory => self,
	:service => service
	)
	end
	end

The fog-aws implementation also doesn't support calling it this way.

[anniesing]

Thanks for re-opening the issue @erjohnso. Let us know if you need any other information that will help with debugging this issue. @elenasharma and I are taking this over from @tcdowney, so feel free to tag us directly as well.

Thanks,
Annie and Elena

[icco]

@anniesing I've merged in @emilymye's PR with a fix, please give it a try.

[maryamklabib]

@icco Thank you, everything seems to work great now. When will the next release be cut?

[icco]

I'll cut now, was just waiting for someone to verify :D

[erjohnso]

@icco 👏 👏 👏 👏 👏