Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian Language #358

Closed
Alator-ux opened this issue Oct 28, 2024 · 6 comments
Closed

Russian Language #358

Alator-ux opened this issue Oct 28, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Alator-ux
Copy link
Contributor

Hello! I’ve finished translating all strings into Russian in Weblate. As mentioned in the Translations section, I’m creating this issue to let you know.
I’m not yet completely sure if the translation is fully accurate, but it’s something I’ll need to verify within the app itself. If I notice anything that needs correction, should I create a new issue, or is there another preferred way to communicate updates (and would it be necessary to do so)?

@Alator-ux Alator-ux added the enhancement New feature or request label Oct 28, 2024
@fmasa
Copy link
Owner

fmasa commented Oct 29, 2024

Hi. Thank you for contribution 👍

I merged the translations. You can enroll into testing track to get version of the app built from master using this link https://play.google.com/apps/testing/cz.frantisekmasa.dnd to test it (I added the settings option in #359).
Once you are happy with the translation, let me know and I will tag a new release 🙂

@fmasa
Copy link
Owner

fmasa commented Oct 29, 2024

If I notice anything that needs correction, should I create a new issue, or is there another preferred way to communicate updates (and would it be necessary to do so)?

If you have any questions, just @ me in this issue. Otherwise if you want to change some translation, you can do that either via Weblate UI (it will automatically send PR [like this one] to this repository and I will merge it) or creating PR manually (whichever way you prefer). 🙂

@Alator-ux
Copy link
Contributor Author

Hello again.
I have tested the translation and made adjustments to some strings. Everything now looks correct, and the translation is ready to be included in the release. If I notice any errors or improvements in the future, I'll update them.

@Alator-ux
Copy link
Contributor Author

I also found a bug where 'Fumble' is displayed without a space from the numbers after a dice roll. For example, it might look like this: 99 vs 35Fumble.

@fmasa
Copy link
Owner

fmasa commented Nov 5, 2024

Everything now looks correct, and the translation is ready to be included in the release. If I notice any errors or improvements in the future, I'll update them.

Nice! 👍 I will tag a new release in a few minutes.

I also found a bug where 'Fumble' is displayed without a space from the numbers after a dice roll. For example, it might look like this: 99 vs 35Fumble.

Thanks, fixed in #365

@fmasa
Copy link
Owner

fmasa commented Nov 5, 2024

This is now released as part of 3.20.0. Thanks again!

@fmasa fmasa closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants