feat: Allow copying an entire session #91
Conversation
|
@web2ls I'm not sure if you are still working on this PR of it's ready for review but regardless this feature will need a test. After you are done feel free to ping me or "request" my review. |
fmaclen
changed the title
|
@fmaclen please check it |
| @@ -177,6 +190,7 @@ | |||
|
|
|||
| <svelte:fragment slot="nav"> | |||
| {#if !isNewSession} | |||
| <CopyButton content={sessionContent} title="Copy session" /> | |||
There was a problem hiding this comment.
I think we can simplify the implementation significantly by doing this:
| <CopyButton content={sessionContent} title="Copy session" /> | |
| <CopyButton content={JSON.stringify(session.messages, null, 2)} /> |
Then we can get rid of the copySessionContent() function and the sessionContent variable.
The result will retain the structure of the session which is useful if you are pasting this session into new session as knowledge/context or another LLM entirely:
[
{
"role": "user",
"content": "mic check, 1 2 3"
},
{
"role": "ai",
"content": "Checking the microphone input, 1...2...3."
},
{
"role": "user",
"content": "hello hello"
},
{
"role": "ai",
"content": "Hello! Is there anything I can assist you with today? If you have any questions or need assistance, please feel free to ask."
}
]Keeping the structure of the message will also be really useful for #54
| export let title: string; | ||
|
|
||
| function copyContent() { | ||
| navigator.clipboard.writeText(content); | ||
| } | ||
| </script> | ||
|
|
||
| <span class="copy-button"> | ||
| <Button title="Copy" variant="icon" size="icon" on:click={copyContent}> | ||
| <Button title={title} variant="icon" size="icon" on:click={copyContent}> |
There was a problem hiding this comment.
Let's keep the default title="Copy" attribute for now and remove the export let title: string;.
tests/session.test.ts
Outdated
| await page.getByText('Sessions', { exact: true }).click(); | ||
| await mockCompletionResponse(page, MOCK_SESSION_1_RESPONSE_1); | ||
| await page.getByTestId('new-session').click(); | ||
| await expect(page.getByTitle('Copy session')).toHaveCount(0); |
There was a problem hiding this comment.
After removing the custom title attribute you can target the "Copy session" button with:
await expect(page.locator(".header").getByTitle('Copy')).toHaveCount(0);There was a problem hiding this comment.
Also, minor formatting issue, can you add an empty line after this assertion?
I'd like to group interactions + assertions in "blocks" separated by empty lines.
|
I just merged #90 and there are 2 minor conflicts in your branch. Also, this PR is almost done and I would like to merge it soon if you can, if you can't that's ok, just give me a heads up. |
|
@fmaclen |
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #87