-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple knowledges per session #73
Comments
@raychz thanks for the detailed suggestion! The way I was thinking about this feature is as follows:
Yeah, agreed. Wouldn't set a limit.
This is an important detail, adding a bunch of context at once could easily exceed the context window of the model.
In general, I'd like to avoid expecting the user to know which value to set It'd be great if we can count the tokens of the current context + prompt (#7) before submitting the form. Looks like there is an ongoing discussion about it: ollama/ollama#1716 If Ollama doesn't have a tokenizer we can use, can we use a 3rd party one? The other caveat is that each model has a different context window, does Ollama report this value via the API? Here's where I'm at:
The UI overhaul should have an impact on some of these features but should be minimal for tasks 1 and 4. [*] I actually have a prototype Chrome extension that extracts the text from the current tab, |
This feature will likely be covered by #116 |
Support for Multiple Knowledge Bases per Session
Current Situation
Currently, Hollama allows users to select a single knowledge entry per session. This limits the flexibility and depth of information that can be incorporated into a single conversation.
Feature Request
We propose adding support for selecting and using multiple knowledges within a single session. This would allow users to combine different sources of information, creating more comprehensive and versatile conversational contexts.
Proposed Functionality
User Interface Updates:
Logic Changes:
Benefits
Implementation Considerations
num_ctx
param would come in handy. See Ollama docs.CONTEXT
tags? Here's a relevant snippet fromollama.ts
.Message
interface would need to be updated to support a list ofKnowledges
. Maybe these two should be decoupled? Or better yet, maybe only theSession
interface should contain the list ofKnowledge
's. Here's the relevant snippet fromsessions.ts
:Questions for Discussion
Thanks for your consideration @fmaclen! I might have time to take this one on soon if you'd like, but I know you're working on a major UI overhaul, so maybe I'll wait until that one is merged in.
The text was updated successfully, but these errors were encountered: