Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow clearing the language input #196

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

GregoMac1
Copy link
Collaborator

Added an allowClear prop to FieldSelect, which defaults to true but is set to false in this case.

@GregoMac1 GregoMac1 self-assigned this Sep 23, 2024
@GregoMac1 GregoMac1 linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

Deploying hollama with  Cloudflare Pages  Cloudflare Pages

Latest commit: 660b4ca
Status: ✅  Deploy successful!
Preview URL: https://f08df080.hollama.pages.dev
Branch Preview URL: https://185-language-combobox-disall.hollama.pages.dev

View logs

Copy link
Owner

@fmaclen fmaclen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 😎

@GregoMac1 GregoMac1 merged commit bab09c5 into main Sep 23, 2024
@GregoMac1 GregoMac1 deleted the 185-language-combobox-disallow-clear branch September 23, 2024 16:21
@fmaclen
Copy link
Owner

fmaclen commented Sep 23, 2024

🎉 This PR is included in version 0.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language combobox shouldn't have a "clear" option
2 participants