-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] flytectl unit tests failing #5316
Comments
Commenting out these lines resolves the issue for the compile_tests which fail intermittently flyte/flytectl/cmd/testutils/test_utils.go Lines 47 to 55 in f59e5ae
This code is used for redirecting the stdout and stderr which helps in verifying in messages printed when executing the commands which are shown to the users https://github.com/flyteorg/flyte/blob/master/flytectl/cmd/testutils/test_utils.go#L102-L113 Unclear yet whats causing this for these particular tests Tried running for 100 iteration
Without commenting
|
Nice find! Thanks for taking a look. Let me confirm we don't really need those lines there. |
Describe the bug
flytectl unit tests are failing pretty consistently in CI.
Tests run locally and only fail occasionally.
Here's the full output:
Expected behavior
flytectl unit tests pass and can be set as required.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: