Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Secret volumes do not get mounted for sidecar/pod tasks #1451

Closed
katrogan opened this issue Sep 8, 2021 · 5 comments
Closed

[BUG] Secret volumes do not get mounted for sidecar/pod tasks #1451

katrogan opened this issue Sep 8, 2021 · 5 comments
Assignees
@katrogan @mayitbeegh
Labels
bug Something isn't working plugins Plugins related labels (backend or frontend)
Milestone
0.18.1

Comments

@katrogan
Copy link
Contributor

katrogan commented Sep 8, 2021

Describe the bug
Secret volumes should be mounted for all pod task containers as defined in the pod spec.

Expected behavior
Secrets should be added to pod task executions.

[Optional] Additional context
To Reproduce
Steps to reproduce the behavior:
1.
2.

Screenshots
If applicable, add screenshots to help explain your problem.
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 8, 2021
@katrogan katrogan self-assigned this Sep 8, 2021
@katrogan katrogan added plugins Plugins related labels (backend or frontend) and removed untriaged This issues has not yet been looked at by the Maintainers labels Sep 8, 2021
@katrogan katrogan added this to the 0.18.0 milestone Sep 8, 2021
@mayitbeegh mayitbeegh self-assigned this Oct 1, 2021
@eapolinario eapolinario modified the milestones: 0.18.0, 0.18.1 Oct 6, 2021
@mayitbeegh mayitbeegh mentioned this issue Oct 8, 2021
Closed
8 tasks
@mayitbeegh
Copy link
Contributor

Fixed in flyteorg/flytepropeller#330

@katrogan
Copy link
Contributor Author

@mayitbeegh were you able to verify the fix worked in attaching secret volumes for pod tasks?

@mayitbeegh
Copy link
Contributor

I verified the fix in flyteorg/flytepropeller#332 for pod tasks and flyteorg/flytepropeller#330 should yield identical results. Do you want to verify the fix in #330 as well?

@katrogan
Copy link
Contributor Author

that sounds great, thanks for confirming!

@mayitbeegh
Copy link
Contributor

Screen Shot 2021-10-11 at 20 01 26

Verified with v0.14.11 flytepropeller webhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

@mayitbeegh mayitbeegh

Labels
bug Something isn't working plugins Plugins related labels (backend or frontend)
Projects
None yet
Milestone
0.18.1
Development

No branches or pull requests
4 participants
@eapolinario @katrogan @mayitbeegh @kumare3