From fceba3cfe2f5bea8826d14dd39c9d5903648b8b4 Mon Sep 17 00:00:00 2001 From: pmahindrakar-oss Date: Wed, 18 Sep 2024 07:45:50 -0700 Subject: [PATCH] add unsupported version tests Signed-off-by: pmahindrakar-oss --- .../pkg/controller/config/config_test.go | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/flytepropeller/pkg/controller/config/config_test.go b/flytepropeller/pkg/controller/config/config_test.go index 60f8d70f88..574a47646d 100644 --- a/flytepropeller/pkg/controller/config/config_test.go +++ b/flytepropeller/pkg/controller/config/config_test.go @@ -68,4 +68,20 @@ func TestIsSupportedSDKVersion(t *testing.T) { } assert.True(t, config.IsSupportedSDKVersion("flytekit", "v1.13.6b0")) }) + t.Run("unsupported dev version", func(t *testing.T) { + config := LiteralOffloadingConfig{ + SupportedSDKVersions: map[string]string{ + "flytekit": "1.13.4", + }, + } + assert.False(t, config.IsSupportedSDKVersion("flytekit", "1.13.3.dev12+g990b450ea.d20240917")) + }) + t.Run("unsupported beta version", func(t *testing.T) { + config := LiteralOffloadingConfig{ + SupportedSDKVersions: map[string]string{ + "flytekit": "1.13.4", + }, + } + assert.False(t, config.IsSupportedSDKVersion("flytekit", "v1.13.3b0")) + }) }