From 9484e368128f40bce85a7560021c505cc3191af4 Mon Sep 17 00:00:00 2001 From: Jason Parraga Date: Wed, 12 Jun 2024 09:11:07 -0700 Subject: [PATCH] Minor cleanup for Web API plugins (#5472) Signed-off-by: Jason Parraga --- flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go | 3 --- flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go index 176b627b91..3912507c75 100644 --- a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go +++ b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go @@ -54,9 +54,6 @@ type State struct { // level retries, just errors from hitting API, inside the sync loop SyncFailureCount int `json:"syncFailureCount,omitempty"` - // In creating the resource, this is the number of failures - CreationFailureCount int `json:"creationFailureCount,omitempty"` - // The time the execution first requests for an allocation token AllocationTokenRequestStartTime time.Time `json:"allocationTokenRequestStartTime,omitempty"` diff --git a/flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go b/flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go index 920040cab0..bd7edaa7a0 100644 --- a/flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go +++ b/flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go @@ -22,7 +22,7 @@ import ( // that the plugin loader will be called before any Handle/Abort/Finalize functions are invoked type PluginLoader func(ctx context.Context, iCtx PluginSetupContext) (AsyncPlugin, error) -// PluginEntry is a structure that is used to indicate to the system a K8s plugin +// PluginEntry is a structure that is used to indicate to the system a WebAPI plugin type PluginEntry struct { // ID/Name of the plugin. This will be used to identify this plugin and has to be unique in the entire system // All functions like enabling and disabling a plugin use this ID