-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix i2c issues found (param and division by zero) #56
Conversation
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
Tested both patches (parameter error and division by zero), everything works fine. Please merge into main as appropriate. ros@turtle:~/bno055_ws$ ros2 run bno055 bno055 --ros-args --params-file ~/bno055_ws/src/bno055/bno055/params/bno055_params_i2c.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine in my testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine in my testing
@slgrobotics thanks for reporting the issue and testing! |
Closes #55