Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SOPS to v3.9.0 #1195

Closed
aivanov-citc opened this issue Jul 2, 2024 · 7 comments · Fixed by #1212
Closed

Update SOPS to v3.9.0 #1195

aivanov-citc opened this issue Jul 2, 2024 · 7 comments · Fixed by #1212

Comments

@aivanov-citc
Copy link

Please, update sops to v3.9.0

We're really looking forward to this feature:

  • Add --mac-only-encrypted to compute MAC only over values which end up encrypted
@julienkosinski
Copy link

julienkosinski commented Jul 22, 2024

Hi @stefanprodan. This new version fix lots of CVEs. In my opinion, this should be a priority...
getsops/sops#1453 (comment)

@stefanprodan
Copy link
Member

@aivanov-citc did you tried the latest SOPS CLI and it didn't work with Flux?

@julienkosinski what makes you think we use the SOPS binary?

@aivanov-citc
Copy link
Author

@stefanprodan yes of course I tried. When encoding a file, sops adds a parameter to the file, I think it is based on this parameter and it is understood that the file is encrypted with this option

sops:
    ...
    mac: ENC[...]
    pgp:
    mac_only_encrypted: true
    version: 3.9.0

when decoding with version 3.8.1 (flux) encoded with version 3.9.0, an error occurs

MAC mismatch.

@stefanprodan
Copy link
Member

So MAC mismatch is an error returned by kustomize-controller?

@aivanov-citc
Copy link
Author

@stefanprodan hmm... very strange, but it works in kustomize-controller.
The question with "mac_only_encrypted" is closed

@stefanprodan
Copy link
Member

It's not strange, we had support for partially encrypted files since years ago.

@julienkosinski
Copy link

@stefanprodan I know it's used as a dependency. I admit I have not checked if CVEs still applies, and in what cases and extents, in this very case. Thank you for making me aware of the difference, and sorry for tagging you if it wasn't necessary... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants