From dda1d355b718e41ed3b0f2ee09faa5cba35d93c5 Mon Sep 17 00:00:00 2001 From: Stevo Slavic Date: Tue, 11 Feb 2025 15:17:29 +0100 Subject: [PATCH] fix: use HelmRelease max history for rollback remediation Signed-off-by: Stevo Slavic --- internal/action/rollback.go | 1 + internal/action/rollback_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/internal/action/rollback.go b/internal/action/rollback.go index 559cb5dfb..34d77a97b 100644 --- a/internal/action/rollback.go +++ b/internal/action/rollback.go @@ -65,6 +65,7 @@ func newRollback(config *helmaction.Configuration, obj *v2.HelmRelease, opts []R rollback.Force = obj.GetRollback().Force rollback.Recreate = obj.GetRollback().Recreate rollback.CleanupOnFail = obj.GetRollback().CleanupOnFail + rollback.MaxHistory = obj.GetMaxHistory() for _, opt := range opts { opt(rollback) diff --git a/internal/action/rollback_test.go b/internal/action/rollback_test.go index f300d94c3..267cc53dc 100644 --- a/internal/action/rollback_test.go +++ b/internal/action/rollback_test.go @@ -49,6 +49,7 @@ func Test_newRollback(t *testing.T) { g.Expect(got).ToNot(BeNil()) g.Expect(got.Timeout).To(Equal(obj.Spec.Rollback.Timeout.Duration)) g.Expect(got.Force).To(Equal(obj.Spec.Rollback.Force)) + g.Expect(got.MaxHistory).To(Equal(obj.GetMaxHistory())) }) t.Run("rollback to version", func(t *testing.T) {