Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get revision after upgrade to 2.0.0.rc.4 #3937

Closed
1 task done
Tracked by #3939
allanhung opened this issue May 31, 2023 · 0 comments · Fixed by fluxcd/helm-controller#695
Closed
1 task done
Tracked by #3939

Unable to get revision after upgrade to 2.0.0.rc.4 #3937

allanhung opened this issue May 31, 2023 · 0 comments · Fixed by fluxcd/helm-controller#695
Labels
area/helm Helm related issues and pull requests bug Something isn't working

Comments

@allanhung
Copy link

Describe the bug

After upgrade to 2.0.0.rc.4, unable to get revision from notification controller.

Steps to reproduce

  1. Follow Promote Flux Helm Releases with GitHub Actions to setup.
  2. When Helm upgrade succeeded, it send out the event to webhook with follow context.
{
  "involvedObject": {
    "kind": "HelmRelease",
    "namespace": "flux-system",
    "name": "test-helm",
    "uid": "c65eeb8b-a138-4c5e-952c-999795aea0bf",
    "apiVersion": "helm.toolkit.fluxcd.io/v2beta1",
    "resourceVersion": "3156284365"
  },
  "severity": "info",
  "timestamp": "2023-05-31T09:41:01Z",
  "message": "Helm upgrade succeeded",
  "reason": "info",
  "metadata": {
    "summary": "env=develop",
    "token": "00c5f2c429523e3b1f26939ed76a8e37ea11c479"
  },
  "reportingController": "helm-controller",
  "reportingInstance": "helm-controller-7999cf497b-sxzst"
}

Expected behavior

It should contain the revision in metadata. (Here is the output from version 2.0.0.rc.3)

{
  "involvedObject": {
    "kind": "HelmRelease",
    "namespace": "flux-system",
    "name": "test-helm",
    "uid": "c65eeb8b-a138-4c5e-952c-999795aea0bf",
    "apiVersion": "helm.toolkit.fluxcd.io/v2beta1",
    "resourceVersion": "3156308417"
  },
  "severity": "info",
  "timestamp": "2023-05-31T09:56:16Z",
  "message": "Helm upgrade succeeded",
  "reason": "info",
  "metadata": {
    "revision": "13.0.3",
    "summary": "env=develop"
  },
  "reportingController": "helm-controller",
  "reportingInstance": "helm-controller-6cbdcf6995-vr8n6"
}

Screenshots and recordings

No response

OS / Distro

macOS 10.15

Flux version

flux: v0.38.3

Flux check

► checking prerequisites
✗ flux 0.38.3 <2.0.0-rc.4 (new version is available, please upgrade)
✔ Kubernetes 1.24.6 >=1.20.6-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.34.0
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v1.0.0-rc.4
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v1.0.0-rc.4
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v1.0.0-rc.4
► checking crds
✔ alerts.notification.toolkit.fluxcd.io/v1beta2
✔ buckets.source.toolkit.fluxcd.io/v1beta2
✔ gitrepositories.source.toolkit.fluxcd.io/v1
✔ helmcharts.source.toolkit.fluxcd.io/v1beta2
✔ helmreleases.helm.toolkit.fluxcd.io/v2beta1
✔ helmrepositories.source.toolkit.fluxcd.io/v1beta2
✔ kustomizations.kustomize.toolkit.fluxcd.io/v1
✔ ocirepositories.source.toolkit.fluxcd.io/v1beta2
✔ providers.notification.toolkit.fluxcd.io/v1beta2
✔ receivers.notification.toolkit.fluxcd.io/v1
✔ all checks passed

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants