Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use git repo rather than cluster state in release calculations #1026

Closed
squaremo opened this issue Mar 27, 2018 · 3 comments
Closed

Use git repo rather than cluster state in release calculations #1026

squaremo opened this issue Mar 27, 2018 · 3 comments

Comments

@squaremo
Copy link
Member

When we do an automation run, we compare the state of the cluster to the available images, then apply the differences to the git repo. This mostly does what you'd want in practice, but it relies on the cluster state being mostly equal to what's in the git repo, and that is not always the case.

For example, this sequence is possible:

  1. the image DB sees a new tag :v2 for an image and fetches its metadata;
  2. the automator looks at the cluster, and sees that it is running :v1, and there is a new image :v2 available;
  3. the automator commits a change that updates the image to :v2 and pushes it upstream;
  4. the commit is fetched from the upstream repo;
  5. the automator looks at the cluster, and sees that it is running :v1, and there is a new image :v2 available;
  6. the automator tries to commit a change but there is no change to be made.

Usually this is harmless, but occasionally, if other things get changed at the same time, it will result in some bogus annotations (and therefore bogus events).

Instead, it would be better if the automation (and push-button releases) looked at the config as given by the git repo, and only used the cluster state to determine whether operations are safe to go ahead.

@squaremo squaremo changed the title Use git repo rather than cluster state in automation calculations Use git repo rather than cluster state in release calculations Mar 27, 2018
@squaremo squaremo self-assigned this Mar 27, 2018
@jml
Copy link

jml commented May 1, 2018

What's the status on this? @aaron7 thinks there's been recent progress.

This is the last open issue in the Deploy onboarding project.

@squaremo
Copy link
Member Author

(This is now done for automated releases, but not for push-button releases, so keeping it open.)

@kingdonb
Copy link
Member

kingdonb commented Apr 6, 2021

This behavior is now wholly different in Flux v2, and likely won't be fixed any further in the context of Flux v1 maintenance mode.

@kingdonb kingdonb closed this as completed Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants