From 313ad34edd1846a5d493c22f266ee0a5093e4c40 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Mon, 13 Jun 2022 12:36:49 -0700 Subject: [PATCH 1/3] Verify a bool value is returned --- .../example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m | 2 ++ .../ios/Classes/FWFWebsiteDataStoreHostApi.m | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m index 18bc21facd21..cd1967ea2aab 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m @@ -70,6 +70,8 @@ - (void)testRemoveDataOfTypes { blockError = error; }]; XCTAssertEqualObjects(returnValue, @YES); + // Asserts whether the NSNumber value represents a BOOL. + XCTAssertEqual(CFBooleanGetTypeID(), CFGetTypeID((__bridge CFTypeRef)(returnValue))); XCTAssertNil(blockError); } @end diff --git a/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebsiteDataStoreHostApi.m b/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebsiteDataStoreHostApi.m index 4587917ba640..0fd85e010a0a 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebsiteDataStoreHostApi.m +++ b/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebsiteDataStoreHostApi.m @@ -60,7 +60,7 @@ - (void)createDefaultDataStoreWithIdentifier:(nonnull NSNumber *)identifier modifiedSince:[NSDate dateWithTimeIntervalSince1970: modificationTimeInSecondsSinceEpoch.doubleValue] completionHandler:^{ - completion(@(records.count > 0), nil); + completion([NSNumber numberWithBool:(records.count > 0)], nil); }]; }]; } From b3f70c6ed43c6e43cfc1317c2d1c42a173798c3c Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 14 Jun 2022 12:58:27 -0700 Subject: [PATCH 2/3] improve comment --- .../example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m index cd1967ea2aab..5d068e4db8ba 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m @@ -70,7 +70,7 @@ - (void)testRemoveDataOfTypes { blockError = error; }]; XCTAssertEqualObjects(returnValue, @YES); - // Asserts whether the NSNumber value represents a BOOL. + // Asserts whether the NSNumber will be deserialized by the standard codec as a boolean. XCTAssertEqual(CFBooleanGetTypeID(), CFGetTypeID((__bridge CFTypeRef)(returnValue))); XCTAssertNil(blockError); } From 6d26140c89ca314b9d04357baa5b14b722b8cf4b Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 14 Jun 2022 19:35:07 -0700 Subject: [PATCH 3/3] switch sides --- .../example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m index 5d068e4db8ba..c518f55194c4 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebsiteDataStoreHostApiTests.m @@ -71,7 +71,7 @@ - (void)testRemoveDataOfTypes { }]; XCTAssertEqualObjects(returnValue, @YES); // Asserts whether the NSNumber will be deserialized by the standard codec as a boolean. - XCTAssertEqual(CFBooleanGetTypeID(), CFGetTypeID((__bridge CFTypeRef)(returnValue))); + XCTAssertEqual(CFGetTypeID((__bridge CFTypeRef)(returnValue)), CFBooleanGetTypeID()); XCTAssertNil(blockError); } @end