-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter_platform_interface] Convert BitmapDescriptor
to typesafe subclasses
#7699
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f267e01
Convert DefaultMarker
yaakovschectman 1705306
Convert BytesBitmap
yaakovschectman 8c3a086
Convert AssetBitmap
yaakovschectman 510dbac
Convert AssetImageBitmap
yaakovschectman a7ccb6b
Convet AssetMapBitmap
yaakovschectman 3066ecc
Convert BytesMapBitmap
yaakovschectman 3c8a00a
Convert BitmapDescriptor to abstract
yaakovschectman 0fb4809
Update tests
yaakovschectman ae91edb
Doc comment
yaakovschectman a10ef96
Format
yaakovschectman 480772c
Cleanup
yaakovschectman daa5918
Mark hue as named
yaakovschectman cdcae66
Mark for testing
yaakovschectman 2d2acfa
Whitespace
yaakovschectman 4d52d25
Import correct annotation
yaakovschectman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Convet AssetMapBitmap
- Loading branch information
commit a7ccb6ba0c03dc2531c2eaab5a54b781c7493928
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be private so we're not increasing the API surface of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you prefer we mark it
@visibleForTesting
, or remove the test https://github.com/flutter/packages/pull/7699/files#diff-a8066076d538f1e1e21b27bac466302cb9317b643500ce81b991102a94611070R685?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be visible for testing and keep the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be my thought as well, @stuartmorgan do you agree with this decision?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine; from a semver standpoint we consider those equivalent.