From d6d8abde649d1a0dfdeca1c5d3d9c1d0097490c0 Mon Sep 17 00:00:00 2001 From: James Leahy Date: Wed, 22 Feb 2023 17:14:01 +0100 Subject: [PATCH 1/3] feat: video_player web options --- .../video_player/lib/video_player.dart | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/lib/video_player.dart b/packages/video_player/video_player/lib/video_player.dart index 5bd543cd49ab..d33dbadeac5f 100644 --- a/packages/video_player/video_player/lib/video_player.dart +++ b/packages/video_player/video_player/lib/video_player.dart @@ -14,7 +14,12 @@ import 'package:video_player_platform_interface/video_player_platform_interface. import 'src/closed_caption_file.dart'; export 'package:video_player_platform_interface/video_player_platform_interface.dart' - show DurationRange, DataSourceType, VideoFormat, VideoPlayerOptions; + show + DurationRange, + DataSourceType, + VideoFormat, + VideoPlayerOptions, + VideoPlayerWebOptions; export 'src/closed_caption_file.dart'; @@ -440,6 +445,13 @@ class VideoPlayerController extends ValueNotifier { _creatingCompleter!.complete(null); final Completer initializingCompleter = Completer(); + if (videoPlayerOptions?.webOptions != null) { + await _videoPlayerPlatform.setWebOptions( + _textureId, + videoPlayerOptions!.webOptions!, + ); + } + void eventListener(VideoEvent event) { if (_isDisposed) { return; From 29955711a9f29b76458631f288877174ca0a3885 Mon Sep 17 00:00:00 2001 From: James Leahy Date: Wed, 17 May 2023 11:42:54 +0200 Subject: [PATCH 2/3] feat: split controls into VideoPlayerWebOptionsControls --- packages/video_player/video_player/lib/video_player.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/lib/video_player.dart b/packages/video_player/video_player/lib/video_player.dart index d33dbadeac5f..4baea7936c8a 100644 --- a/packages/video_player/video_player/lib/video_player.dart +++ b/packages/video_player/video_player/lib/video_player.dart @@ -19,7 +19,8 @@ export 'package:video_player_platform_interface/video_player_platform_interface. DataSourceType, VideoFormat, VideoPlayerOptions, - VideoPlayerWebOptions; + VideoPlayerWebOptions, + VideoPlayerWebOptionsControls; export 'src/closed_caption_file.dart'; From 15c25525f937b6fe4310ee86eceaa4b4b7e0ce54 Mon Sep 17 00:00:00 2001 From: James Leahy Date: Tue, 18 Jul 2023 11:52:33 +0200 Subject: [PATCH 3/3] chore: only call setWebOptions in web --- packages/video_player/video_player/lib/video_player.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/video_player/lib/video_player.dart b/packages/video_player/video_player/lib/video_player.dart index 4baea7936c8a..17fa0d12ac29 100644 --- a/packages/video_player/video_player/lib/video_player.dart +++ b/packages/video_player/video_player/lib/video_player.dart @@ -446,7 +446,7 @@ class VideoPlayerController extends ValueNotifier { _creatingCompleter!.complete(null); final Completer initializingCompleter = Completer(); - if (videoPlayerOptions?.webOptions != null) { + if (kIsWeb && videoPlayerOptions?.webOptions != null) { await _videoPlayerPlatform.setWebOptions( _textureId, videoPlayerOptions!.webOptions!,