flutter_plugins analyze step failed on framework ToT, video_player Missing case clause for 'contentUri'.

[jmagman]

�[36mRunning for video_player/video_player...�[0m
Running command: "dart analyze --fatal-infos" in /b/s/w/ir/x/t/flutter_plugins.OSXWBR/packages/video_player/video_player
Analyzing video_player...

warning - lib/video_player.dart:279:5 - Missing case clause for 'contentUri'. Try adding a case clause for the missing constant, or adding a default clause. - missing_enum_constant_in_switch

1 issue found.
�[36mRunning for video_player_platform_interface...�[0m
Running command: "dart analyze --fatal-infos" in /b/s/w/ir/x/t/flutter_plugins.OSXWBR/packages/video_player/video_player_platform_interface
Analyzing video_player_platform_interface...
No issues found!
�[36mRunning for video_player_web...�[0m
Running command: "dart analyze --fatal-infos" in /b/s/w/ir/x/t/flutter_plugins.OSXWBR/packages/video_player/video_player_web
Analyzing video_player_web...

warning - lib/video_player_web.dart:74:5 - Missing case clause for 'contentUri'. Try adding a case clause for the missing constant, or adding a default clause. - missing_enum_constant_in_switch

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8836535742066526897/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/test_stdout

Caused by flutter/plugins#4307

[jmagman]

@stuartmorgan @byunme

[stuartmorgan]

Unfortunately we have an all-local build to catch build errors from updates to dependencies, but not an all-local analyze. I'll need to think about a general solution for that.

For the specific issue, rebasing the other PR on master (and removing the path override) and then landing it to fix forward is probably the easiest solution. It's already approved.

I'm not at my computer, but I can do it later if nobody can do it before then.

[stuartmorgan]

flutter/plugins#4261 is the second PR.

[jmagman]

I'm not at my computer, but I can do it later if nobody can do it before then.

I can do that.

[jmagman]

Working on the merge conflicts now, the PR hasn't been rebased in awhile.

[jmagman]

flutter/plugins#4261 is the second PR.

This doesn't fix video_player_web. Who should take a look at that? I added it as a no-op to flutter/plugins#4330

[stuartmorgan]

Thanks for cleaning up my mess @jmagman !

[jmagman]

Thanks for cleaning up my mess @jmagman !

Well you don't get to claim any monopoly on mess, it's all our mess! Mess solidarity!

[stuartmorgan]

Well you don't get to claim any monopoly on mess

It's hard not to feel a significant amount of ownership here when I thought "hmm, won't adding an enum cause issues for case statements?" before deciding that the CI would have flagged that and approving it 😒

[jmagman]

flutter/plugins#4330 is in, I merged a flutter/flutter commit to kick the tree.

[jmagman]

I merged a flutter/flutter commit to kick the tree.

Although I did it too soon, the plugin hasn't been published yet. Will merge another once it does.

[byunme]

So sorry for all the trouble!

[jmagman]

No worries @byunme this definitely wasn't your fault, the non-breaking interface change/analysis error is a process issue, not anything to do with your change.

[jmagman]

The test is still failing due to an unrelated plugins tooling issue tracked in #89805. It's been turned off for now while that can be investigated.

Plugin tree is green again, and the plugins roll with the fix has been merged #89803.
Closing this as fixed.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.