From 777d7cc9878dada550d3b676e399154d7dc350c2 Mon Sep 17 00:00:00 2001
From: Zachary Anderson <zanderso@users.noreply.github.com>
Date: Fri, 12 Jan 2024 22:35:12 +0000
Subject: [PATCH] Make engine build configs test exempt (#3405)

For example for PRs like https://github.com/flutter/engine/pull/49776
---
 .../src/request_handlers/github/webhook_subscription.dart  | 2 ++
 .../request_handlers/github/webhook_subscription_test.dart | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
index 2bfb3e0f7..78d04242e 100644
--- a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
+++ b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
@@ -404,6 +404,8 @@ class GithubWebhookSubscription extends SubscriptionHandler {
           !_isTestExempt(filename) &&
           // License goldens are auto-generated.
           !filename.startsWith('ci/licenses_golden/') &&
+          // Build configuration files tell CI what to run.
+          !filename.startsWith('ci/builders/') &&
           // Build files don't need unit tests.
           !filename.endsWith('.gn') &&
           !filename.endsWith('.gni')) {
diff --git a/app_dart/test/request_handlers/github/webhook_subscription_test.dart b/app_dart/test/request_handlers/github/webhook_subscription_test.dart
index 3019a7fcb..4cf76f0fe 100644
--- a/app_dart/test/request_handlers/github/webhook_subscription_test.dart
+++ b/app_dart/test/request_handlers/github/webhook_subscription_test.dart
@@ -1523,7 +1523,7 @@ void foo() {
       );
     });
 
-    test('Engine labels PRs, no comment for license goldens', () async {
+    test('Engine labels PRs, no comment for license goldens or build configs', () async {
       const int issueNumber = 123;
 
       tester.message = generateGithubWebhookMessage(
@@ -1534,9 +1534,10 @@ void foo() {
       );
 
       when(pullRequestsService.listFiles(Config.engineSlug, issueNumber)).thenAnswer(
-        (_) => Stream<PullRequestFile>.value(
+        (_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
           PullRequestFile()..filename = 'ci/licenses_golden/licenses_dart',
-        ),
+          PullRequestFile()..filename = 'ci/builders/linux_unopt.json',
+        ]),
       );
 
       await tester.post(webhook);