Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds minimum_cruise_ratio support #1260

Conversation

pedrolamas
Copy link
Member

Adds support for Klipper's new minimum_cruise_ratio (keeping accel_to_decel support as legacy) as specified here: Klipper3d/klipper#6418

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Dec 6, 2023
@pedrolamas pedrolamas added this to the 1.26.4 milestone Dec 6, 2023
@pedrolamas pedrolamas requested a review from matmen December 6, 2023 14:36
@pedrolamas pedrolamas force-pushed the pedrolamas/minimum-cruise-ratio-support branch from 8120983 to fb0326a Compare December 6, 2023 17:19
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one small comment:

matmen
matmen previously approved these changes Dec 8, 2023
@pedrolamas pedrolamas removed this from the 1.27 milestone Dec 8, 2023
@pedrolamas pedrolamas force-pushed the pedrolamas/minimum-cruise-ratio-support branch from 249140a to dad0e28 Compare December 9, 2023 01:12
@pedrolamas pedrolamas added this to the 1.27 milestone Dec 9, 2023
@pedrolamas pedrolamas merged commit ea03875 into fluidd-core:develop Dec 9, 2023
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/minimum-cruise-ratio-support branch December 9, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants