feat: adds WebRTC (go2rtc) support #1245
Conversation
This reverts commit 708aa19.
clean up linting Signed-off-by: vajonam <vajonam@github>
clean up lint Signed-off-by: vajonam <vajonam@github>
| ref="streamingElement" | ||
| autoplay | ||
| playsinline | ||
| controls |
There was a problem hiding this comment.
We don't have controls on the other players, not sure we should have on this one either.
| controls |
There was a problem hiding this comment.
controls is nice to have to allow us to pop out the player or cast it.. think its a value add in this case.
There was a problem hiding this comment.
In that case, only enable it in full screen mode.
Having it on the card can easily interfere with the controls we add.
There was a problem hiding this comment.
also allows for audio to be unmuted, nice to have a feature that you just listen for a print to start and then mute. but I am okay as long.
Co-authored-by: Pedro Lamas <[email protected]> Signed-off-by: vajonam <[email protected]>
fixed up search all not replacing name and as result the name it self, now th Signed-off-by: vajonam <vajonam@github>
feat: go2rtc support fix missing colon! Singed-off-by: vajonam <vajonam@github>
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
changed the title
There was a problem hiding this comment.
Thank you @vajonam, can you please add a footer to the main PR comment with a "Signed-off-by" line, following the CONTRIBUTING guidelines.
|
Done. |
feat: webrtc go2rtc support
https://go2rtc.domain.com/webrtc/stream.html?src=trident&mode=mseSigned-off-by: vajonam vajonam@github