Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_tail uses regexp to split lines #1324

Closed
tagomoris opened this issue Nov 25, 2016 · 0 comments · Fixed by #1325
Closed

in_tail uses regexp to split lines #1324

tagomoris opened this issue Nov 25, 2016 · 0 comments · Fixed by #1325
Labels
enhancement Feature request or improve operations

Comments

@tagomoris
Copy link
Member

https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/in_tail.rb#L573

It's much slower than using index and slice!.
Here's a micro bench code and its result:
https://gist.github.com/tagomoris/d9cf1e961378ab553b65fbaa844ba6df
@tagomoris tagomoris added the enhancement Feature request or improve operations label Nov 25, 2016
@tagomoris tagomoris mentioned this issue Nov 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize to split lines fluent/fluentd
1 participant
@tagomoris