fix(CapacitiesTable): fix duration in tooltip #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
bot
temporarily deployed
to
Preview – network-explorer-stage
vercel
bot
temporarily deployed
to
Preview – network-explorer-testnet
vercel
bot
temporarily deployed
to
Preview – network-explorer-mainnet
vercel
bot
temporarily deployed
to
Preview – network-explorer-stage
vercel
bot
temporarily deployed
to
Preview – network-explorer-mainnet
vercel
bot
temporarily deployed
to
Preview – network-explorer-testnet
DieMyst
reviewed
Sep 16, 2024
| @@ -129,7 +132,7 @@ export const CapacitiesTable: React.FC<CapacitiesTableProps> = ({ | |||
| <Tooltip trigger={<InfoOutlineIcon />}> | |||
| <Text color="grey600" weight={600} size={12}> | |||
| Duration capacity commitment in epochs. Currently, one epoch is | |||
| set as 24 hours. | |||
| set as {formatDistanceToNowStrict(Date.now() + epochDuration)} | |||
There was a problem hiding this comment.
I guess you can use just formatDistanceStrict without Date.now()
There was a problem hiding this comment.
I added formatDuration fn
vercel
bot
temporarily deployed
to
Preview – network-explorer-stage
DieMyst
reviewed
Sep 16, 2024
src/utils/formatDuration.ts
Outdated
| import { formatDistanceStrict } from 'date-fns' | ||
|
|
||
| export function formatDuration(duration: number) { | ||
| return formatDistanceStrict(Date.now() + duration, Date.now(), { |
There was a problem hiding this comment.
formatDistanceStrict(duration, 0... will be simplier
vercel
bot
temporarily deployed
to
Preview – network-explorer-mainnet
vercel
bot
temporarily deployed
to
Preview – network-explorer-testnet
DieMyst
approved these changes
Sep 16, 2024
vercel
bot
temporarily deployed
to
Preview – network-explorer-stage
vercel
bot
temporarily deployed
to
Preview – network-explorer-mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.