Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non-uniformly typed Maps #33

Closed
Skn0tt opened this issue Jul 30, 2020 · 1 comment · Fixed by #37
Closed

Add support for non-uniformly typed Maps #33

Skn0tt opened this issue Jul 30, 2020 · 1 comment · Fixed by #37

Comments

@Skn0tt
Copy link
Collaborator

Skn0tt commented Jul 30, 2020 •
edited
Loading

At the moment, we don't support Map<number | string, RegExp>, because the keys of Map { 1 => /a/g, "1" => /b/g } would clash, as both keys serialise to { "1": "/a/g" } / { "1": "/b/g" }.

The same holds true for other key type combinations, of course.
@Skn0tt
Copy link
Collaborator Author

Skn0tt commented Jul 30, 2020

This issue should be much easier to solve once #35 is resolved.

@Skn0tt Skn0tt mentioned this issue Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialize Map using a list of pairs flightcontrolhq/superjson
1 participant
@Skn0tt