Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SuperJSONResult type #271

Closed
tmcw opened this issue Oct 23, 2023 · 2 comments · Fixed by #272
Closed

Export SuperJSONResult type #271

tmcw opened this issue Oct 23, 2023 · 2 comments · Fixed by #272

Comments

@tmcw
Copy link
Contributor

tmcw commented Oct 23, 2023

We were previously using SuperJSON v1, and importing from dist/types to get the SuperJSONResult type. Now that it's at v2 and there's an explicit exports entry in superjson, we can't do that, and it'd be nicer if index.ts re-exported SuperJSONResult to make that access possible.

This is for things like making sure that a zod parser that tests whether a value is "like" a SuperJSONResult is accurate, or just for typing the output of functions that return SuperJSON-serialized data.

@Skn0tt
Copy link
Collaborator

Skn0tt commented Oct 24, 2023

That's a good idea! Do you wanna open another PR for this?

@tmcw
Copy link
Contributor Author

tmcw commented Oct 24, 2023

Sure! PR: #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants