New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in PrimitveJSONValue type #168

Closed

icflorescu opened this issue Feb 6, 2022 · 1 comment · Fixed by #171

icflorescu commented Feb 6, 2022

There's a typo in PrimitveJSONValue type here:

https://github.com/blitz-js/superjson/blob/c5bee351d2e25821600cd8e04b018e7c423b9f77/src/types.ts#L6

I could come up with a PR to fix it if needed, but I have no idea on how this should be handled so it won't become a breaking change.

Skn0tt linked a pull request

that will close this issue

fix: typo in type (Closes #168) #171

Merged

Collaborator

Skn0tt commented Feb 14, 2022

The type isn't exported anywhere consumable from clients, so it should be fine to just rename it :) Opened a PR!

Skn0tt closed this as completed in #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment