kubeadm/cilium: bump tested versions #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Cilium 1.12, {live,ready}ness probes are on :9879 while
it was on :9876 on older versions. (See: cilium/cilium@22cd47e)
CLI made this change on versions greater or equal to 1.10.12 (See: https://github.com/cilium/cilium-cli/pull/869/files) - it
results with a port mismatch 9879/9876 if we test the version 1.11.5.
Basically Cilium is running fine but its status is not ready/healthy
from a Kubernetes PoV.
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/kubeadm
branch
from
ee76175 to
6e68db3
Compare
krnowak
approved these changes
Aug 31, 2022
kola/tests/kubeadm/kubeadm.go
Outdated
| @@ -54,8 +54,12 @@ var ( | |||
| _ = c.MustSSH(controller, "/opt/bin/cilium uninstall") | |||
| version := params["CiliumVersion"].(string) | |||
| cidr := params["PodSubnet"].(string) | |||
| cmd := fmt.Sprintf("/opt/bin/cilium install --config enable-endpoint-routes=true --config cluster-pool-ipv4-cidr=%s --version=%s --encryption=ipsec --wait --wait-duration 1m", cidr, version) | |||
| _ = c.MustSSH(controller, cmd) | |||
| cmd := fmt.Sprintf("/opt/bin/cilium install --config enable-endpoint-routes=true --config cluster-pool-ipv4-cidr=%s --version=%s --encryption=ipsec --wait-duration=1s --rollback=false", cidr, version) | |||
There was a problem hiding this comment.
Specifying wait duration is most likely pointless if we are not waiting:
Suggested change
| cmd := fmt.Sprintf("/opt/bin/cilium install --config enable-endpoint-routes=true --config cluster-pool-ipv4-cidr=%s --version=%s --encryption=ipsec --wait-duration=1s --rollback=false", cidr, version) | |
| cmd := fmt.Sprintf("/opt/bin/cilium install --config enable-endpoint-routes=true --config cluster-pool-ipv4-cidr=%s --version=%s --encryption=ipsec --rollback=false", cidr, version) |
There was a problem hiding this comment.
It actually waits (--wait defaults to true) - but it made me think that we can --wait=false --restart-unmanaged-pods=false to not wait at all, this is enough for this test case.
There was a problem hiding this comment.
Cool. If that works then feel free to merge the PR.
This is required even with Permissive mode. Can be dropped once `spc_t` is supported on Flatcar. Signed-off-by: Mathieu Tortuyaux <[email protected]>
Once the daemon set is started with `unconfined_t` it does not work with enforced SELinux because it hits a denial from transitioning to `kernel_t` to `unconfined_t` (and this normal because currently everything runs with `kernel_t` including container runtimes) Can be dropped once it works fine with `spc_t` label with the SELinux upgrade. Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/kubeadm
branch
from
d335d57 to
a6333e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubeadm/cilium: bump CLI and tested Cilium version
Starting from Cilium 1.12, {live,ready}ness probes are on :9879 while
it was on :9876 on older versions. (See: cilium/cilium@22cd47e)
CLI made this change on versions greater or equal to 1.10.12 (See: https://github.com/cilium/cilium-cli/pull/869/files) - it
results with a port mismatch 9879/9876 if we test the version 1.11.5.
Basically Cilium is running fine but its status is not ready/healthy
from a Kubernetes PoV.
kubeadm/cilium: patch Cilium daemon set
This is required even with Permissive mode. Can be dropped once
spc_tis supported on Flatcar.
kubeadm/cilium: disable SELinux for Cilium
Once the daemon set is started with
unconfined_tit does not work withenforced SELinux because it hits a denial from transitioning to
kernel_ttounconfined_t(and this normal because currently everything runs withkernel_tincluding container runtimes)Can be dropped once it works fine with
spc_tlabel with the SELinuxupgrade.
Tested multiple times on Openstack, the CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/packet/309/console and with kubernetes-1.25