Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s 1.25 to kubeadm tests #360

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Add k8s 1.25 to kubeadm tests #360

merged 3 commits into from
Aug 31, 2022

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Aug 24, 2022

Also comes with a script that get the checksums.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@krnowak krnowak force-pushed the krnowak/k8s-1.25 branch 2 times, most recently from 196feb0 to a782973 Compare August 24, 2022 11:53
@krnowak
Copy link
Member Author

krnowak commented Aug 25, 2022

Running the tests again (testing my test dispatcher job at the same time):

@krnowak
Copy link
Member Author

krnowak commented Aug 25, 2022

It looks like it will need more investigation:

[2022-08-25T13:38:22.437Z] --- FAIL: kubeadm.v1.25.0.cilium.base (1085.71s)
[2022-08-25T13:38:22.437Z]         kubeadm.go:248: unable to setup cluster: unable to create master node: Future#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded

@krnowak
Copy link
Member Author

krnowak commented Aug 26, 2022

Now it fails somewhere inside cilium install with a message cilium version not found: open cilium-1.12.1.tgz: file does not exist. This line actually comes from this place: https://github.com/cilium/cilium-cli/blob/master/internal/helm/helm.go#L186-L194

@tormath1
Copy link
Contributor

Now it fails somewhere inside cilium install with a message cilium version not found: open cilium-1.12.1.tgz: file does not exist. This line actually comes from this place: https://github.com/cilium/cilium-cli/blob/master/internal/helm/helm.go#L186-L194

It looks like Cilium CLI now uses Helm charts to generate Cilium manifest. Helm charts are versioned in the vendors, and the version 1.12.1 has been added in the following commit: cilium/cilium-cli@4216e69 not yet released.

@krnowak
Copy link
Member Author

krnowak commented Aug 30, 2022

Bumped cilium cli to 0.12.2 (released 4 days ago), so it should now support cilium 1.12.1. Let's see now.

@krnowak
Copy link
Member Author

krnowak commented Aug 30, 2022

Running the tests again:

@tormath1
Copy link
Contributor

tormath1 commented Aug 30, 2022

while trying this branch:

  Normal   Pulled     107s (x5 over 3m17s)  kubelet            Container image "quay.io/cilium/cilium:v1.12.1@sha256:ea2db1ee21b88127b5c18a96ad155c25485d0815a667ef77c2b7c7f31cab601b" already present on machine
  Normal   Created    107s (x5 over 3m17s)  kubelet            Created container mount-cgroup
  Warning  Failed     107s (x5 over 3m17s)  kubelet            Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: write /proc/self/attr/keycreate: invalid argument: unknown
  Warning  BackOff    93s (x10 over 3m16s)  kubelet            Back-off restarting failed container

that sounds like a SELinux issue but got the same result with permissive mode.

EDIT: fixed with #365

@krnowak
Copy link
Member Author

krnowak commented Aug 31, 2022

For now I merged #365 here to get the docker container, so I can test adding k8s 1.25 with those fixes.

@krnowak
Copy link
Member Author

krnowak commented Aug 31, 2022

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good. Feel free to merge once rebased on flatcar-master. 🎉 Thanks for the script :)

Invoke the script to get checksums for all the tested k8s versions,
call with -N to get only for the first N listed k8s versions (so
currently calling it with -1 will get checksums for k8s 1.25.0).
@krnowak krnowak marked this pull request as ready for review August 31, 2022 11:28
@krnowak krnowak merged commit b33e59c into flatcar-master Aug 31, 2022
@krnowak krnowak deleted the krnowak/k8s-1.25 branch August 31, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants