kola: More calico fixes #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
force-pushed
the
krnowak/more-calico-fixes
branch
from
03b7230 to
a9fe693
Compare
This is to minimize the differences between upstream definition file and our modified one.
We were often getting an error like: error: unable to recognize "calico.yaml": no matches for kind "Installation" in version "operator.tigera.io/v1"
krnowak
force-pushed
the
krnowak/more-calico-fixes
branch
from
a9fe693 to
5adf559
Compare
krnowak
changed the title
|
Another test run: http://jenkins.infra.kinvolk.io:8080/job/container/job/test/1989/console |
|
Tested with my toolchain update build: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/204/cldsv/ |
tormath1
reviewed
Aug 24, 2022
tormath1
approved these changes
Aug 24, 2022
|
Thanks for the review. I just remembered that this needs an entry in the changelog. Added one and merged. If you have some suggestions about the entry, I'll fix eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll need to update the github action to mention in the created PR that these templates should be manually compared with the original versions.There seemed to be a race between using one manifest file to create CRDs and afterwards applying another manifest file that was using those CRDs. Sometimes the CRDs were not established, so the resources of that type could not be used. Use
kubectl waitto make sure that those CRDs are ready.While at it, sync our modified custom-resources.yaml manifest with the upstream and add a note about it to the github action. The note looks like in this PR: krnowak#2.
Test run: http://jenkins.infra.kinvolk.io:8080/job/container/job/test/1988/console (note the
customresourcedefinition.apiextensions.k8s.io/installations.operator.tigera.io condition metline in the output, after CRDs were created, but before the object of that type was created).